Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Guava to 20.0.0 #348

Closed
elharo opened this issue Mar 6, 2017 · 4 comments
Closed

Update Guava to 20.0.0 #348

elharo opened this issue Mar 6, 2017 · 4 comments
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@elharo
Copy link
Contributor

elharo commented Mar 6, 2017

21 requires Java 8, so stick with 20

@garrettjonesgoogle
Copy link
Member

@ejona86 , I haven't looked over the surface of this repo yet - what is the rule for exposing Guava from google-http-java-client?

If Guava is exposed to consumers, the 17.0 -> 20.0 upgrade will be somewhat disruptive; they are more than 2 years apart, meaning that code against the earlier version may break when the runtime is the later version.

@ejona86
Copy link
Contributor

ejona86 commented Mar 22, 2017

20 broke a lot of gRPC users, and due to some Precondition overloads added to 20 users can't force a lower version. gRPC decided to downgrade to 19 for the moment to allow time for the libraries to catch up.

I'd suggest updating to 19 here as well.

@mattwhisenhunt
Copy link
Contributor

Fixed in #380.

@garrettjonesgoogle
Copy link
Member

For those checking after the fact, we settled with Guava 19.0.

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this issue Aug 11, 2022
* updated versions.txt [ci skip]

* updated appengine/pom.xml [ci skip]

* updated bom/pom.xml [ci skip]

* updated credentials/pom.xml [ci skip]

* updated oauth2_http/pom.xml [ci skip]

* updated pom.xml [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

5 participants