Update to Guava 20.0 #352
Closed
Update to Guava 20.0 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should go past 19.0 for now. See grpc/grpc-java#2751 |
|
Hm. While that would probably have other benefits, that wouldn't solve the referenced issue. |
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guava-jdk5 17.0 is very old: 3 years, which is beyond the supported lifetime of Guava. Additionally, guava on jdk5 is no longer supported since Java 5 has been EOL for a while.
This library depending on a very old version of guava was first reported here: google/dagger#651
I don't know what to do with the files in
google-http-client-assembly/dependencies/but those look to be out of date anyway.Note that I didn't update to Guava 21, since that version requires Java 8.