Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Centipede compatible with as many existing projects as possible. #9583

Open
DonggeLiu opened this issue Feb 5, 2023 · 6 comments
Open

Make Centipede compatible with as many existing projects as possible. #9583

DonggeLiu opened this issue Feb 5, 2023 · 6 comments
Assignees
@DonggeLiu

Comments

@DonggeLiu
Copy link
Contributor

Due to the large number of projects in OSS-Fuzz, this issue keeps track of projects that are/were incompatible with Centipede and how they are gradually made compatible by #9427.

The reason for incompatibility is collected and summarised in this spreadsheet.

The progress is tracked by this spreadsheet, where the columns are the commit IDs from #9427.
@DonggeLiu DonggeLiu self-assigned this Feb 5, 2023
@jonathanmetzman
Copy link
Contributor

Do you know why a lot of these are failing with compile_centipede doesn't exist. That's very bizarre

@jonathanmetzman
Copy link
Contributor

Doing some tests, it seems like a ton of space in centipede builds can be taken up by corpora. So I think #9587 and #9346 will help a lot.

@jonathanmetzman
Copy link
Contributor

I think librawspeed's issue is interesting. https://pantheon.corp.google.com/cloud-build/builds;region=us-central1/39202e47-3fb1-4646-9d22-38f0404901d8?project=oss-fuzz
I think it may be fixed by not using the seed corpus, but we might need another fix in the form of using different working dir for each fuzzer that get deleted after each test.

@jonathanmetzman
Copy link
Contributor

Related: #9299

@jonathanmetzman jonathanmetzman mentioned this issue Feb 6, 2023
Merged
@jonathanmetzman
Copy link
Contributor

Related: #9299

Ah those are projects that are pinned to an older image

@jonathanmetzman jonathanmetzman mentioned this issue Feb 6, 2023
Merged
@jonathanmetzman
Copy link
Contributor

upb and jwt-verify-lib may work now because of #9507

jonathanmetzman added a commit that referenced this issue Feb 6, 2023
@jonathanmetzman
Don't hold back images that can be upgraded.
3ca851d 
This allows these projects to be compiled with centipede
Related: #9583
This was referenced Feb 6, 2023
Merged
Merged
Closed
jonathanmetzman added a commit that referenced this issue Feb 7, 2023
@jonathanmetzman
Don't use -fsanitize=fuzzer-no-link with centipede
413ba4f 
It's pointless and has these drawbacks:
1. It add useless instrumentation not used by centipede that slows
down the target
2. It adds instrumentation that expects an implementation at link
time (__sancov_lowest_stack) which can break projects builds.

Fixes #9609
Related: #9299 #9583
@jonathanmetzman jonathanmetzman mentioned this issue Feb 7, 2023
Merged
jonathanmetzman added a commit that referenced this issue Feb 7, 2023
@jonathanmetzman
Don't hold back images that can be upgraded. (#9602)
18f3e32 
This allows these projects to be compiled with centipede
Related: #9583
@jonathanmetzman jonathanmetzman mentioned this issue Feb 7, 2023
Closed
jonathanmetzman added a commit that referenced this issue Feb 7, 2023
@jonathanmetzman
Don't use -fsanitize=fuzzer-no-link with centipede (#9610)
5444805 
It's pointless and has these drawbacks:
1. It add useless instrumentation not used by centipede that slows down
the target
2. It adds instrumentation that expects an implementation at link time
(__sancov_lowest_stack) which can break projects builds.

Fixes #9609
Related: #9299
#9583
@jonathanmetzman jonathanmetzman mentioned this issue Feb 7, 2023
Merged
eamonnmcmanus pushed a commit to eamonnmcmanus/oss-fuzz that referenced this issue Mar 15, 2023
@jonathanmetzman @eamonnmcmanus
Don't hold back images that can be upgraded. (google#9602)
6283ddb 
This allows these projects to be compiled with centipede
Related: google#9583
eamonnmcmanus pushed a commit to eamonnmcmanus/oss-fuzz that referenced this issue Mar 15, 2023
@jonathanmetzman @eamonnmcmanus
Don't use -fsanitize=fuzzer-no-link with centipede (google#9610)
18744cd 
It's pointless and has these drawbacks:
1. It add useless instrumentation not used by centipede that slows down
the target
2. It adds instrumentation that expects an implementation at link time
(__sancov_lowest_stack) which can break projects builds.

Fixes google#9609
Related: google#9299
google#9583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DonggeLiu DonggeLiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DonggeLiu @jonathanmetzman