Skip to content

Commit

Permalink
Don't use -fsanitize=fuzzer-no-link with centipede (google#9610)
Browse files Browse the repository at this point in the history
It's pointless and has these drawbacks:
1. It add useless instrumentation not used by centipede that slows down
the target
2. It adds instrumentation that expects an implementation at link time
(__sancov_lowest_stack) which can break projects builds.

Fixes google#9609
Related: google#9299
google#9583
  • Loading branch information
jonathanmetzman authored and eamonnmcmanus committed Mar 15, 2023
1 parent 8ce6f8b commit 18744cd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion infra/base-images/base-builder/compile
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ then
fi

# Don't need coverage instrumentation for engine-less, afl++ builds.
if [ $FUZZING_ENGINE = "none" ] || [ $FUZZING_ENGINE = "afl" ]; then
if [ $FUZZING_ENGINE = "none" ] || [ $FUZZING_ENGINE = "afl" ] || [ $FUZZING_ENGINE = "centipede" ] ; then
export COVERAGE_FLAGS=
fi

Expand Down

0 comments on commit 18744cd

Please sign in to comment.