Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hold back images that can be upgraded. #9602

Merged
merged 8 commits into from
Feb 7, 2023
Merged

Conversation

jonathanmetzman
Copy link
Contributor

This allows these projects to be compiled with centipede
Related: #9583

This allows these projects to be compiled with centipede
Related: #9583
@jonathanmetzman
Copy link
Contributor Author

/gcbrun trial_build.py wasmtime wolfssl bearssl php num-bigint relic libecc nettle

@jonathanmetzman
Copy link
Contributor Author

/gcbrun trial_build.py wasmtime wolfssl bearssl php num-bigint relic libecc nettle

@jonathanmetzman
Copy link
Contributor Author

I want to use gcbrun to see if this breaks coverage

@jonathanmetzman
Copy link
Contributor Author

Relic coverage failure on GHA is out-of-space (spurious)

@jonathanmetzman
Copy link
Contributor Author

@jonathanmetzman
Copy link
Contributor Author

/gcbrun skip

Copy link
Contributor

@DonggeLiu DonggeLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
How do we determine if we can upgrade an image?
For example, php is also not using the latest image, can we upgrade it?

@jonathanmetzman
Copy link
Contributor Author

LGTM. How do we determine if we can upgrade an image? For example, php is also not using the latest image, can we upgrade it?

I held back projects that break with newer images. Determining if they can be upgraded is straightforward, just check that the build works :-) We could even automate this.

@jonathanmetzman jonathanmetzman merged commit 18f3e32 into master Feb 7, 2023
@jonathanmetzman jonathanmetzman deleted the cent-opt-out branch February 7, 2023 00:34
eamonnmcmanus pushed a commit to eamonnmcmanus/oss-fuzz that referenced this pull request Mar 15, 2023
This allows these projects to be compiled with centipede
Related: google#9583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants