Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag for cmake to generate IE11 compatible JS decoder modules #405

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented May 25, 2018

The current JavaScript decoder module fails when run in IE11.

This allows an IE_COMPATIBLE variable to be set when generating the cmake files in order to build a module that works in IE11 by providing polyfills, at a small hit to module size (1MB), with the solution proposed in emscripten-core/emscripten#6204

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@ggetz
Copy link
Contributor Author

ggetz commented May 25, 2018

I've signed the CLA

@googlebot
Copy link

CLAs look good, thanks!

@tomfinegan tomfinegan self-assigned this Jun 7, 2018
@tomfinegan tomfinegan merged commit 83cbf6c into google:master Jun 8, 2018
@ggetz ggetz deleted the ie-compatibility-js-decoder branch June 8, 2018 16:17
danielgronlund pushed a commit to danielgronlund/draco that referenced this pull request Aug 22, 2024
Add a flag for cmake to generate IE11 compatible JS decoder modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants