Draco js module build instructions #6672
Conversation
|
@ggetz, thanks for the pull request! Maintainers, we have a signed CLA from @ggetz, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
| 1. Clone or download the [Draco release](https://github.com/google/draco/releases). | ||
| 2. [Download and install Emscripten](https://kripken.github.io/emscripten-site/docs/getting_started/downloads.html) | ||
| 3. Download and install a make tool. | ||
| * For instance, [MSYS2](http://www.msys2.org/). Follow installation instructions and add the path to MSYS2's usr/bin to your `PATH`. For example, if the path is `C:\msys64\usr\bin`, run `PATH=%PATH%;C:\msys64\usr\bin`. |
There was a problem hiding this comment.
Should we instead just recommend using Linux to build, and point to Ubuntu 18.04 Subsystem for Windows users? I found the build process easier there.
| * For instance, [MSYS2](http://www.msys2.org/). Follow installation instructions and add the path to MSYS2's usr/bin to your `PATH`. For example, if the path is `C:\msys64\usr\bin`, run `PATH=%PATH%;C:\msys64\usr\bin`. | ||
| 4. In a seperate directory, follow the [CMake JavaScript Encoder/Decoder Instructions](https://github.com/google/draco#javascript-encoderdecoder). When running cmake, specify `"Unix Makefiles"` as the target, and including the flag `-DIE_COMPATIBLE=true`, ie. | ||
| ```terminal | ||
| cmake ..\path\to\draco -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="absolute\path\emscripten\cmake\Modules\Platforms\Emscripten.cmake" -DIE_COMPATIBLE |
There was a problem hiding this comment.
-DIE_COMPATIBLE is missing =true
|
Thanks @lilleyse, updated! Added a line preferring Linux or the subsystem, but left previous instructions as an optional backup. |
|
Looks good. Does anyone else have feedback or want to try this out? |
|
Looks good to me. Sounds like building is trivial if you're already familiar with cmake/unix dev tools. Thanks @ggetz! |
| 1. Download and install a make tool. | ||
| * Preferably, use Linux or [the Linux Subsystem for Windows 10](https://docs.microsoft.com/en-us/windows/wsl/install-win10) and `make` to build. | ||
| * Optionally, [MSYS2](http://www.msys2.org/). Follow installation instructions and add the path to MSYS2's usr/bin to your `PATH`. For example, if the path is `C:\msys64\usr\bin`, run `PATH=%PATH%;C:\msys64\usr\bin`. | ||
| 2. Clone or download the [Draco release](https://github.com/google/draco/releases). |
There was a problem hiding this comment.
Actually, one comment. If you clone Draco from git, you'll get master and not an official release, right? We should probably always include an official release in Cesium
|
Thanks @mramato. Meant to imply that, but it wasn't particularly clear so I made it more explicit. |
|
The updated wording looks good to me. |
Added instructions for updating the draco module, following PR with update to draco build options: google/draco#405