Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if the model is compressed, it does not work in IE11 browser #7987

Closed
vaseala opened this issue Apr 6, 2020 · 4 comments · Fixed by #7990
Closed

if the model is compressed, it does not work in IE11 browser #7987

vaseala opened this issue Apr 6, 2020 · 4 comments · Fixed by #7990
Assignees
Milestone

Comments

@vaseala
Copy link

vaseala commented Apr 6, 2020

Bugs

descriptions

I had read the forum , but can not solve the problem。

links

model uncompressed
model compressed

files description

box.glb

a simple model, only has a simple cube model, then exported from blender.

box.min.glb

the same model with box.glb, just use compression when export.

compressed.html

render the box.min.glb model

uncompressed.html

render the box.glb model

@vaseala vaseala changed the title if the model is compressed, it dose not work in IE11 browser if the model is compressed, it does not work in IE11 browser Apr 6, 2020
@deltakosh
Copy link
Contributor

Pinging @bghgary (I guess this is probably related to promise polyfill?)

@deltakosh deltakosh added this to the 4.2 milestone Apr 6, 2020
@bghgary bghgary added the in progress Someone is currently working on this issue label Apr 6, 2020
@bghgary
Copy link
Contributor

bghgary commented Apr 6, 2020

I don't believe this ever worked. Draco has to be compiled with a flag to enable IE and I've never compiled Draco until I investigated this issue. But even after I do that, there are some issues that I can't resolve easily.

I'm trying to figure out what happened with emsdk/emscripten such it now wants to use Promise in the fallback Draco js, but I have some trouble.

Here are all the relevant links:

google/draco#405

This PR adds a flag you can pass to Draco CMake so that it can build for IE. I don't believe this flag is enabled for the pre-built versions, but I'm not 100% sure.

google/draco#596

I filed this issue to see if Draco folks can help with this.

@deltakosh deltakosh removed the bug label Apr 6, 2020
@bghgary bghgary removed the in progress Someone is currently working on this issue label Apr 6, 2020
@bghgary
Copy link
Contributor

bghgary commented Apr 6, 2020

https://forum.babylonjs.com/t/ie11-promise-is-not-defined/9438

@vaseala
Copy link
Author

vaseala commented Apr 11, 2020

It helped me a lot!
@bghgary thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants