Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a reason that the IE_COMPATIBLE build option was removed in 1.3.4? #466

Closed
benpurdy opened this issue Sep 25, 2018 · 0 comments
Closed

Is there a reason that the IE_COMPATIBLE build option was removed in 1.3.4? #466

benpurdy opened this issue Sep 25, 2018 · 0 comments

Comments

@benpurdy
Copy link

Please forgive me if this is obvious as I'm quite new to this project (and emscripten as a whole) but is there some reason that the IE_COMPATIBLE option was removed from this project in version 1.3.4? It was added via PR #405 but in 1.3.4 it seems to have been removed.

I was able to re-add this functionality by editing my CMakeLists.txt similarly to how it worked in the code from the PR referenced above and I was able to build a version of draco_decoder.js which runs fine in IE11.

I'm wondering if the IE_COMPATIBLE option was removed by accident?
tomfinegan added a commit that referenced this issue Sep 26, 2018
@tomfinegan
Restore IE support.
9648d72 
Closes #466
@tomfinegan tomfinegan mentioned this issue Sep 26, 2018
Merged
dyangrun added a commit to dyangrun/draco that referenced this issue Apr 29, 2019
@dyangrun
Squashed commit of the following:
b097fca 
commit 785c9c4
Merge: deef28e a32c1f0
Author: Lou Quillio <[email protected]>
Date:   Wed Mar 13 13:52:24 2019 -0700

    Merge pull request google#511 from louquillio/update-copyright-footer

    Update page footer template to display current year in copyright legend.

commit a32c1f0
Author: Lou Quillio <[email protected]>
Date:   Wed Mar 13 13:49:10 2019 -0700

    Update page footer template to display current year in copyright legend.

    Hopefully also kicks off a gh-pages rebuild.

commit deef28e
Merge: bb91e08 df1d453
Author: Lou Quillio <[email protected]>
Date:   Wed Mar 13 13:36:41 2019 -0700

    Merge pull request google#510 from louquillio/update-gems

    Update gems to address reported vulnerabilities.

commit df1d453
Author: Lou Quillio <[email protected]>
Date:   Wed Mar 13 13:32:33 2019 -0700

    Update gems to address reported vulnerabilities.

commit bb91e08
Author: Katrin Leinweber <[email protected]>
Date:   Wed Mar 6 00:37:34 2019 +0100

    Hyperlink DOI to preferred resolver (google#501)

    See https://www.doi.org/doi_handbook/3_Resolution.html#3.8

commit 265bbfc
Author: Frederic L <[email protected]>
Date:   Wed Mar 6 00:33:20 2019 +0100

    attributes/point_d_vector: Prevent a singend/unsigned mismatch (google#489)

commit d132946
Author: thibault <[email protected]>
Date:   Wed Mar 6 00:26:12 2019 +0100

    Remove useless semicolons after macros (google#473)

commit 8833cf8
Author: Igor Vytyaz <[email protected]>
Date:   Thu Jan 31 10:18:06 2019 -0800

    Updated snapshot to 1.3.5
    * Added option to build Draco for Universal Scene Description
    * Code cleanup
    * Bug fixes

commit e9337d1
Merge: eee8bf5 9648d72
Author: Tom Finegan <[email protected]>
Date:   Wed Sep 26 09:21:16 2018 -0700

    Merge pull request google#468 from google/restore_ie_compat

    Restore IE support.

commit 9648d72
Author: Tom Finegan <[email protected]>
Date:   Wed Sep 26 08:52:07 2018 -0700

    Restore IE support.

    Closes google#466

commit eee8bf5
Merge: 063994c 407c1d5
Author: FrankGalligan <[email protected]>
Date:   Mon Aug 20 16:04:59 2018 -0700

    Merge pull request google#455 from FreddyFunk/update_contributing_for_styleguide

    Update CONTRIBUTING.md

commit 407c1d5
Author: Frederic Laing <[email protected]>
Date:   Sun Aug 19 16:54:50 2018 +0200

    Update CONTRIBUTING.md

commit 063994c
Author: Frank Galligan <[email protected]>
Date:   Fri Aug 17 12:01:27 2018 -0700

    Update snapshot to 1.3.4

commit c93f507
Merge: e3a9d6c 5c15f38
Author: FrankGalligan <[email protected]>
Date:   Wed Aug 15 09:04:52 2018 -0700

    Merge pull request google#452 from google/fix_shared_nmake_build

    Fix NMake builds with BUILD_SHARED_LIBS enabled.

commit 5c15f38
Author: Tom Finegan <[email protected]>
Date:   Tue Aug 14 15:14:30 2018 -0700

    Fix NMake builds with BUILD_SHARED_LIBS enabled.

    Fixes google#328

# Conflicts:
#	CMakeLists.txt
danielgronlund pushed a commit to danielgronlund/draco that referenced this issue Aug 22, 2024
@tomfinegan
Restore IE support.
263f509 
Closes google#466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benpurdy