-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-DBUILD_SHARED_LIBS on MSVC fails #328
Comments
Reproduced with: Works with: |
Does this mean that Draco is MSVC 2017+ only? |
That's a warning. Have you added -DENABLE_WERROR=1 to your CMake command line, or somehow added /WX to your cl.exe command lines? |
Yes, there were a number of warnings. That's ok
|
Sorry, I forgot to mention that it builds just fine for me on both 2017 and 2015 with |
Can you run the nmake build in verbose mode? This should work: Is any additional information provided w/VERBOSE enabled? Are any targets working? Which target is NMake building when the error is reported? |
|
Thanks for the fix. I just tried it out and I get past building the draco.dll, but the tests do not build completely (they build without trouble in a static, non-
|
I won't have time to look into this for at least a couple of days, as far as workarounds go: Just disable the tests when doing shared library builds for now. I suspect the fix for this may be to avoid use of the CMake support in googletest in favor of referencing the sources directly as a static library in the Draco CMake file. If you want to try that yourself it's not very difficult. Basically:
I think that's it. If you try this and run into any issues: Please post them here. |
Reporting back that the tests are running for me now. There's a failure, but I'll make a new ticket for it. |
commit 785c9c4 Merge: deef28e a32c1f0 Author: Lou Quillio <[email protected]> Date: Wed Mar 13 13:52:24 2019 -0700 Merge pull request google#511 from louquillio/update-copyright-footer Update page footer template to display current year in copyright legend. commit a32c1f0 Author: Lou Quillio <[email protected]> Date: Wed Mar 13 13:49:10 2019 -0700 Update page footer template to display current year in copyright legend. Hopefully also kicks off a gh-pages rebuild. commit deef28e Merge: bb91e08 df1d453 Author: Lou Quillio <[email protected]> Date: Wed Mar 13 13:36:41 2019 -0700 Merge pull request google#510 from louquillio/update-gems Update gems to address reported vulnerabilities. commit df1d453 Author: Lou Quillio <[email protected]> Date: Wed Mar 13 13:32:33 2019 -0700 Update gems to address reported vulnerabilities. commit bb91e08 Author: Katrin Leinweber <[email protected]> Date: Wed Mar 6 00:37:34 2019 +0100 Hyperlink DOI to preferred resolver (google#501) See https://www.doi.org/doi_handbook/3_Resolution.html#3.8 commit 265bbfc Author: Frederic L <[email protected]> Date: Wed Mar 6 00:33:20 2019 +0100 attributes/point_d_vector: Prevent a singend/unsigned mismatch (google#489) commit d132946 Author: thibault <[email protected]> Date: Wed Mar 6 00:26:12 2019 +0100 Remove useless semicolons after macros (google#473) commit 8833cf8 Author: Igor Vytyaz <[email protected]> Date: Thu Jan 31 10:18:06 2019 -0800 Updated snapshot to 1.3.5 * Added option to build Draco for Universal Scene Description * Code cleanup * Bug fixes commit e9337d1 Merge: eee8bf5 9648d72 Author: Tom Finegan <[email protected]> Date: Wed Sep 26 09:21:16 2018 -0700 Merge pull request google#468 from google/restore_ie_compat Restore IE support. commit 9648d72 Author: Tom Finegan <[email protected]> Date: Wed Sep 26 08:52:07 2018 -0700 Restore IE support. Closes google#466 commit eee8bf5 Merge: 063994c 407c1d5 Author: FrankGalligan <[email protected]> Date: Mon Aug 20 16:04:59 2018 -0700 Merge pull request google#455 from FreddyFunk/update_contributing_for_styleguide Update CONTRIBUTING.md commit 407c1d5 Author: Frederic Laing <[email protected]> Date: Sun Aug 19 16:54:50 2018 +0200 Update CONTRIBUTING.md commit 063994c Author: Frank Galligan <[email protected]> Date: Fri Aug 17 12:01:27 2018 -0700 Update snapshot to 1.3.4 commit c93f507 Merge: e3a9d6c 5c15f38 Author: FrankGalligan <[email protected]> Date: Wed Aug 15 09:04:52 2018 -0700 Merge pull request google#452 from google/fix_shared_nmake_build Fix NMake builds with BUILD_SHARED_LIBS enabled. commit 5c15f38 Author: Tom Finegan <[email protected]> Date: Tue Aug 14 15:14:30 2018 -0700 Fix NMake builds with BUILD_SHARED_LIBS enabled. Fixes google#328 # Conflicts: # CMakeLists.txt
Configuring with
-DBUILD_SHARED_LIBS=ON
fails with MSVC 2015:The text was updated successfully, but these errors were encountered: