Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation impact of v2 changes #1463

Closed
mgeisler opened this issue Nov 10, 2023 · 18 comments
Closed

Translation impact of v2 changes #1463

mgeisler opened this issue Nov 10, 2023 · 18 comments

Comments

@mgeisler
Copy link
Collaborator

Head of main

Looking only at the translations linked in our language picker, I see these numbers right now using main:

pt-BR before: 1597 translated messages, 196 fuzzy translations, 727 untranslated messages.
zh-CN before: 1634 translated messages, 193 fuzzy translations, 693 untranslated messages.
zh-TW before: 1505 translated messages, 137 fuzzy translations, 878 untranslated messages.
ko before: 1968 translated messages, 204 fuzzy translations, 348 untranslated messages.
es before: 2018 translated messages, 112 fuzzy translations, 390 untranslated messages.

This is after updating the translations with the newest strings from main:

MDBOOK_OUTPUT='{"xgettext": {"pot-file": "messages.pot"}}' mdbook build -d po
for lang in pt-BR zh-CN zh-TW ko es; do
    msgmerge --update po/$lang.po po/messages.pot
    echo -n "$lang before: "; msgfmt -o /dev/null --stat po/$lang.po
done

Head of cr2-organization

Updating to 9dcb262 on cr2-organization and running the same commands will show the impact of the branch in terms of messages that have been touched. I get these numbers:

pt-BR after: 1086 translated messages, 351 fuzzy translations, 1148 untranslated messages.
zh-CN after: 1160 translated messages, 320 fuzzy translations, 1105 untranslated messages.
zh-TW after: 1019 translated messages, 281 fuzzy translations, 1285 untranslated messages.
ko after: 1453 translated messages, 377 fuzzy translations, 755 untranslated messages.
es after: 1530 translated messages, 274 fuzzy translations, 781 untranslated messages.

In table form:

Language Translated before % Translated after %
pt-BR 1597 63% 1086 42%
zh-CN 1634 65% 1160 45%
zh-TW 1505 60% 1019 39%
ko 1968 78% 1453 56%
es 2018 80% 1530 59%

This suggests that the new material touch about 500 messages, or 1/3 of the content.

Using back-dated sources

Now, the above shows the raw delta between main and cr2-organization. The actual impact on the translations will be different: the translations are published using back-dated sources, sources that match the time of the last msgmerge.

The statistics for the translations right now (using back-dated sources) is:

Language Translated now %
pt-BR 1762 71%
zh-CN 1658 67%
zh-TW 1644 66%
ko 2175 88%
es 2101 86%

Risks

When we introduced the snapshot publishing system in #1243, we also created a risk that a translation will stay behind forever.

I wonder if translations will chose to not jump past the merge point with cr2-organization?

We can mitigate this by having our internal Localization team work on updating the translations after the merge.

@mgeisler
Copy link
Collaborator Author

@henrif75
Copy link
Collaborator

I think using the localization team is the fastest way to have the translations on v2 asap. However, we will need to give a heads up to reviewers to get a fast turnaround.

@mgeisler
Copy link
Collaborator Author

I think using the localization team is the fastest way to have the translations on v2 asap. However, we will need to give a heads up to reviewers to get a fast turnaround.

Yes, I agree! Nothing should break after the merge, but I agree that we should engage with the Localization team to have this translated then.

@mgeisler
Copy link
Collaborator Author

I just ran msgmerge --update on the languages mentioned above and the result is v2-po-files.zip.

I think it would be nice to send these to the Localization team already now. @henrif75, if you split them into days, I would ask the team to translate Day 1 to 3 first. When the PR is merged, you should be able to run mdbook-xgettext to extract the messages again, do another msgmerge --update and send this out for review.

@henrif75
Copy link
Collaborator

I just ran msgmerge --update on the languages mentioned above and the result is v2-po-files.zip.

I think it would be nice to send these to the Localization team already now. @henrif75, if you split them into days, I would ask the team to translate Day 1 to 3 first. When the PR is merged, you should be able to run mdbook-xgettext to extract the messages again, do another msgmerge --update and send this out for review.

SG, I'll start preparing the files and send the translation requests.

@Phosphorus-M
Copy link
Contributor

If we want to update the translation, we do a PR into the fork of @djmitche?
I mean an update of the translation using the new branch.

@mgeisler
Copy link
Collaborator Author

If we want to update the translation, we do a PR into the fork of @djmitche? I mean an update of the translation using the new branch.

Hi @Phosphorus-M! Sorry for the slow reply... It's so cool that you're eager to help out 😄 The branch has just been merged, so you can follow the usual procedure for refreshing a translation: mdbook-xgettext followed by msgmerge!

@Phosphorus-M
Copy link
Contributor

If we want to update the translation, we do a PR into the fork of @djmitche? I mean an update of the translation using the new branch.

Hi @Phosphorus-M! Sorry for the slow reply... It's so cool that you're eager to help out 😄 The branch has just been merged, so you can follow the usual procedure for refreshing a translation: mdbook-xgettext followed by msgmerge!

Great! This night I'm going to check the changes and translate the new texts

@henrif75
Copy link
Collaborator

I just ran msgmerge --update on the languages mentioned above and the result is v2-po-files.zip.
I think it would be nice to send these to the Localization team already now. @henrif75, if you split them into days, I would ask the team to translate Day 1 to 3 first. When the PR is merged, you should be able to run mdbook-xgettext to extract the messages again, do another msgmerge --update and send this out for review.

SG, I'll start preparing the files and send the translation requests.

@mgeisler Congrats on the v2 launch!
I'll start extracting the .po files and send to the localization team, prioritizing first the "officially" published translations (e.g., KR) - except the Spanish (thanks @Phosphorus-M, I'll wait for your PRs!)

@mgeisler
Copy link
Collaborator Author

Thanks @henrif75, that sounds perfect!

@henrif75
Copy link
Collaborator

henrif75 commented Dec 4, 2023

I've sent the KO (#262 ) translation to the localization team.

@henrif75
Copy link
Collaborator

henrif75 commented Dec 4, 2023

zh-CN (#324) translation sent to localization.

henrif75 added a commit to henrif75/comprehensive-rust that referenced this issue Jan 4, 2024
…s. It will set the base to merge the professional translations later (google#1463)
henrif75 added a commit that referenced this issue Jan 4, 2024
Updates the `ko.po` with the v.2 English strings, without adding new
translations.
It will set the base to merge the professional translations later
(#1463).

To avoid disruptions on the live KO version, this will be merged into a
new branch (ko-v2), until all PRs are reviewed.
henrif75 added a commit to henrif75/comprehensive-rust that referenced this issue Jan 4, 2024
henrif75 added a commit that referenced this issue Jan 5, 2024
Updates the `zh-CN.po` (#324) with the v.2 English strings, without
adding new translations.
It will set the base to merge the professional translations later
(#1463).

To avoid disruptions on the live zh-CN version, this will be merged into
a new branch (zh-CN-cr2), until all PRs are reviewed.
henrif75 added a commit that referenced this issue Mar 13, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all zh-TW content is
reviewed.

#1463 #684

---------

Co-authored-by: Ming-Ying Chung <[email protected]>
henrif75 added a commit that referenced this issue Mar 14, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all zh-TW content is
reviewed.

#1463 #684

---------

Co-authored-by: Jonathan Hao <[email protected]>
henrif75 added a commit that referenced this issue Mar 20, 2024
Chromium translations from CR v.2

#262 #1463
henrif75 added a commit that referenced this issue Mar 21, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Kanta Yamaoka (山岡幹太) <[email protected]>
henrif75 added a commit that referenced this issue Mar 22, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all zh-TW content is
reviewed.

#1463 #684

---------

Co-authored-by: Ming-Ying Chung <[email protected]>
henrif75 added a commit that referenced this issue Apr 3, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all zh-TW content is
reviewed.

#1463 #684

---------

Co-authored-by: Ming-Ying Chung <[email protected]>
@mgeisler
Copy link
Collaborator Author

Hi @henrif75, would you like to keep this issue open until the published translations are updated, or can we close it now?

henrif75 added a commit that referenced this issue Apr 22, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Kanta Yamaoka (山岡幹太) <[email protected]>
@henrif75
Copy link
Collaborator

Hi @henrif75, would you like to keep this issue open until the published translations are updated, or can we close it now?

As soon we finish the Japanese translation I can close this issue, thanks.

henrif75 added a commit that referenced this issue May 3, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all zh-TW content is
reviewed.

#1463 #684

---------

Co-authored-by: Jonathan Hao <[email protected]>
henrif75 added a commit that referenced this issue May 7, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652
henrif75 added a commit that referenced this issue May 7, 2024
…nto main (#2037)

This PR merges the Chinese Traditional (zh-TW) CR v.2 translation back
to main.
This requires just a syntactical review, as the partial PRs into this
branch were reviewed already.

You can skim this PR with the [GitHub CLI](https://cli.github.com/):

gh pr diff 2037 | bat -l patch

#1463 #684

---------

Co-authored-by: Victor Hsieh <[email protected]>
Co-authored-by: Ming-Ying Chung <[email protected]>
Co-authored-by: Jonathan Hao <[email protected]>
henrif75 added a commit that referenced this issue May 8, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Hidenori Kobayashi <[email protected]>
henrif75 added a commit that referenced this issue May 15, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all zh-TW content is
reviewed.

#1463 #684

---------

Co-authored-by: Jonathan Hao <[email protected]>
henrif75 added a commit that referenced this issue May 28, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Hidenori Kobayashi <[email protected]>
henrif75 added a commit that referenced this issue May 28, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Hidenori Kobayashi <[email protected]>
henrif75 added a commit that referenced this issue May 31, 2024
This PR merges the Japanese (ja) v.2 translation back to main.
This requires just a syntactical review, as the partial PRs into this
branch were reviewed already.

You can skim this PR with the [GitHub CLI](https://cli.github.com/):

gh pr diff 2103 | bat -l patch

#1463 #652

---------

Co-authored-by: Kanta Yamaoka (山岡幹太) <[email protected]>
Co-authored-by: Hidenori Kobayashi <[email protected]>
henrif75 added a commit that referenced this issue Jun 20, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Hidenori Kobayashi <[email protected]>
henrif75 added a commit that referenced this issue Jul 5, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Hidenori Kobayashi <[email protected]>
@mgeisler
Copy link
Collaborator Author

As soon we finish the Japanese translation I can close this issue, thanks.

@henrif75, did we update the translation?

@henrif75
Copy link
Collaborator

As soon we finish the Japanese translation I can close this issue, thanks.

@henrif75, did we update the translation?

Oh we did, I'm closing it!

@mgeisler
Copy link
Collaborator Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants