-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation impact of v2 changes #1463
Comments
cc @henrif75, @djmitche, @kantasv, @deavid, @jiyongp, @victorhsieh, @Phosphorus-M, @nodmp, etc... |
I think using the localization team is the fastest way to have the translations on v2 asap. However, we will need to give a heads up to reviewers to get a fast turnaround. |
Yes, I agree! Nothing should break after the merge, but I agree that we should engage with the Localization team to have this translated then. |
I just ran I think it would be nice to send these to the Localization team already now. @henrif75, if you split them into days, I would ask the team to translate Day 1 to 3 first. When the PR is merged, you should be able to run |
SG, I'll start preparing the files and send the translation requests. |
If we want to update the translation, we do a PR into the fork of @djmitche? |
Hi @Phosphorus-M! Sorry for the slow reply... It's so cool that you're eager to help out 😄 The branch has just been merged, so you can follow the usual procedure for refreshing a translation: |
Great! This night I'm going to check the changes and translate the new texts |
@mgeisler Congrats on the v2 launch! |
Thanks @henrif75, that sounds perfect! |
I've sent the KO (#262 ) translation to the localization team. |
zh-CN (#324) translation sent to localization. |
…s. It will set the base to merge the professional translations later (google#1463)
Updates the `ko.po` with the v.2 English strings, without adding new translations. It will set the base to merge the professional translations later (#1463). To avoid disruptions on the live KO version, this will be merged into a new branch (ko-v2), until all PRs are reviewed.
Professional translations for CR2 content. Changes are being staged in a separate branch until all zh-TW content is reviewed. #1463 #684 --------- Co-authored-by: Ming-Ying Chung <[email protected]>
Professional translations for CR2 content. Changes are being staged in a separate branch until all zh-TW content is reviewed. #1463 #684 --------- Co-authored-by: Jonathan Hao <[email protected]>
Professional translations for CR2 content. Changes are being staged in a separate branch until all Japanese content is reviewed. #1463 #652 --------- Co-authored-by: Kanta Yamaoka (山岡幹太) <[email protected]>
Professional translations for CR2 content. Changes are being staged in a separate branch until all zh-TW content is reviewed. #1463 #684 --------- Co-authored-by: Ming-Ying Chung <[email protected]>
Professional translations for CR2 content. Changes are being staged in a separate branch until all zh-TW content is reviewed. #1463 #684 --------- Co-authored-by: Ming-Ying Chung <[email protected]>
Hi @henrif75, would you like to keep this issue open until the published translations are updated, or can we close it now? |
Professional translations for CR2 content. Changes are being staged in a separate branch until all Japanese content is reviewed. #1463 #652 --------- Co-authored-by: Kanta Yamaoka (山岡幹太) <[email protected]>
As soon we finish the Japanese translation I can close this issue, thanks. |
Professional translations for CR2 content. Changes are being staged in a separate branch until all zh-TW content is reviewed. #1463 #684 --------- Co-authored-by: Jonathan Hao <[email protected]>
…nto main (#2037) This PR merges the Chinese Traditional (zh-TW) CR v.2 translation back to main. This requires just a syntactical review, as the partial PRs into this branch were reviewed already. You can skim this PR with the [GitHub CLI](https://cli.github.com/): gh pr diff 2037 | bat -l patch #1463 #684 --------- Co-authored-by: Victor Hsieh <[email protected]> Co-authored-by: Ming-Ying Chung <[email protected]> Co-authored-by: Jonathan Hao <[email protected]>
Professional translations for CR2 content. Changes are being staged in a separate branch until all Japanese content is reviewed. #1463 #652 --------- Co-authored-by: Hidenori Kobayashi <[email protected]>
Professional translations for CR2 content. Changes are being staged in a separate branch until all zh-TW content is reviewed. #1463 #684 --------- Co-authored-by: Jonathan Hao <[email protected]>
Professional translations for CR2 content. Changes are being staged in a separate branch until all Japanese content is reviewed. #1463 #652 --------- Co-authored-by: Hidenori Kobayashi <[email protected]>
Professional translations for CR2 content. Changes are being staged in a separate branch until all Japanese content is reviewed. #1463 #652 --------- Co-authored-by: Hidenori Kobayashi <[email protected]>
This PR merges the Japanese (ja) v.2 translation back to main. This requires just a syntactical review, as the partial PRs into this branch were reviewed already. You can skim this PR with the [GitHub CLI](https://cli.github.com/): gh pr diff 2103 | bat -l patch #1463 #652 --------- Co-authored-by: Kanta Yamaoka (山岡幹太) <[email protected]> Co-authored-by: Hidenori Kobayashi <[email protected]>
Professional translations for CR2 content. Changes are being staged in a separate branch until all Japanese content is reviewed. #1463 #652 --------- Co-authored-by: Hidenori Kobayashi <[email protected]>
Professional translations for CR2 content. Changes are being staged in a separate branch until all Japanese content is reviewed. #1463 #652 --------- Co-authored-by: Hidenori Kobayashi <[email protected]>
@henrif75, did we update the translation? |
Oh we did, I'm closing it! |
Thanks a lot! |
Head of
main
Looking only at the translations linked in our language picker, I see these numbers right now using
main
:This is after updating the translations with the newest strings from
main
:Head of
cr2-organization
Updating to 9dcb262 on
cr2-organization
and running the same commands will show the impact of the branch in terms of messages that have been touched. I get these numbers:In table form:
This suggests that the new material touch about 500 messages, or 1/3 of the content.
Using back-dated sources
Now, the above shows the raw delta between
main
andcr2-organization
. The actual impact on the translations will be different: the translations are published using back-dated sources, sources that match the time of the lastmsgmerge
.The statistics for the translations right now (using back-dated sources) is:
Risks
When we introduced the snapshot publishing system in #1243, we also created a risk that a translation will stay behind forever.
I wonder if translations will chose to not jump past the merge point with
cr2-organization
?We can mitigate this by having our internal Localization team work on updating the translations after the merge.
The text was updated successfully, but these errors were encountered: