Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ja: Merge CR v.2 Japanese translation back into main #2103

Merged
merged 7 commits into from
May 31, 2024
Merged

ja: Merge CR v.2 Japanese translation back into main #2103

merged 7 commits into from
May 31, 2024

Conversation

henrif75
Copy link
Collaborator

@henrif75 henrif75 commented May 28, 2024

This PR merges the Japanese (ja) v.2 translation back to main.
This requires just a syntactical review, as the partial PRs into this branch were reviewed already.

You can skim this PR with the GitHub CLI:

gh pr diff 2103 | bat -l patch

#1463 #652

henrif75 and others added 6 commits March 20, 2024 18:07
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Kanta Yamaoka (山岡幹太) <[email protected]>
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Kanta Yamaoka (山岡幹太) <[email protected]>
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Hidenori Kobayashi <[email protected]>
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Hidenori Kobayashi <[email protected]>
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Hidenori Kobayashi <[email protected]>
@mgeisler
Copy link
Collaborator

We can ignore the Prevent unintended msgid changes failure — I think it's a false positive. When I look at the diff, I don't see any changes to the msgid fields.

@henrif75 henrif75 marked this pull request as ready for review May 31, 2024 16:55
@henrif75
Copy link
Collaborator Author

We can ignore the Prevent unintended msgid changes failure — I think it's a false positive. When I look at the diff, I don't see any changes to the msgid fields.

Thanks!
I'll go ahead and merge this, and then we're just waiting for the concurrency and bare-metal modules.

@henrif75 henrif75 merged commit 7d889d3 into main May 31, 2024
35 of 36 checks passed
@henrif75 henrif75 deleted the jp-cr2 branch May 31, 2024 17:58
@henrif75 henrif75 restored the jp-cr2 branch May 31, 2024 17:58
@henrif75 henrif75 deleted the jp-cr2 branch May 31, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants