Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese translation #652

Closed
mgeisler opened this issue May 22, 2023 · 50 comments
Closed

Japanese translation #652

mgeisler opened this issue May 22, 2023 · 50 comments

Comments

@mgeisler
Copy link
Collaborator

The Rust Book has been translated into Japanese. Let us see if we can reuse some of their terminology.

momotaro1105 added a commit to CoinEZ-JPN/comprehensive-rust that referenced this issue May 23, 2023
CoinEZ-JPN added a commit to CoinEZ-JPN/comprehensive-rust that referenced this issue May 23, 2023
keiichiw added a commit to keiichiw/comprehensive-rust that referenced this issue May 25, 2023
chikoski pushed a commit that referenced this issue May 25, 2023
ja: Create initial ja.po file

Start working on #652
momotaro1105 added a commit to CoinEZ-JPN/comprehensive-rust that referenced this issue May 25, 2023
momotaro1105 added a commit to CoinEZ-JPN/comprehensive-rust that referenced this issue May 25, 2023
translation of just the Table of Contents
google#652
keiichiw pushed a commit to CoinEZ-JPN/comprehensive-rust that referenced this issue May 25, 2023
@mgeisler
Copy link
Collaborator Author

Hey @momotaro1105, @keiichiw, @CoinEZ-JPN and other people interested in the Japanese translation.

Just a small note: I've created spreadsheets to help organize some of the other translations, see #684 for an example. That might be useful for you too.

CoinEZ-JPN pushed a commit to CoinEZ-JPN/comprehensive-rust that referenced this issue May 26, 2023
CoinEZ-JPN pushed a commit to CoinEZ-JPN/comprehensive-rust that referenced this issue May 26, 2023
@kantasv
Copy link
Collaborator

kantasv commented May 28, 2023

Hi, I've read your post and would love to contribute to this as a native Japanese speaker :)
Do we already have the spreadsheet for the JA project? Or should I make one?

#652 (comment)

CoinEZ-JPN added a commit to CoinEZ-JPN/comprehensive-rust that referenced this issue May 28, 2023
localhost does not reflect all translations for reasons unknown (ex: 2.3 "With this in place...")
CoinEZ-JPN added a commit to CoinEZ-JPN/comprehensive-rust that referenced this issue May 28, 2023
adding spacing consistency after `:` for table of contents
keiichiw pushed a commit that referenced this issue May 29, 2023
* ja: tooling check (#652)

* updating table of contents based on suggestions

---------

Co-authored-by: Kenta Aratani <[email protected]>
CoinEZ-JPN added a commit to CoinEZ-JPN/comprehensive-rust that referenced this issue May 29, 2023
err-ing on 構文 over 文法, but open to advice
CoinEZ-JPN added a commit to CoinEZ-JPN/comprehensive-rust that referenced this issue May 29, 2023
@CoinEZ-JPN
Copy link
Contributor

hello, just checking - the next PR should come directly from my branch post fetch origin, correct?
and still to this #652?

@keiichiw
Copy link
Collaborator

@CoinEZ-JPN If the branch on your forked repository is based on this repository's main branch and your commit message includes #652, that should be fine.

Note that it would be easier if one pull request translates only one chapter. That's said it'd be nice if you have branches such as japanese-translate-ch-3 or japanese-translate-ch-4 for each chapter.

CoinEZ-JPN added a commit to CoinEZ-JPN/comprehensive-rust that referenced this issue May 30, 2023
localhost does not reflect all translations for reasons unknown (ex: 2.3 "With this in place...")
CoinEZ-JPN added a commit to CoinEZ-JPN/comprehensive-rust that referenced this issue May 30, 2023
localhost does not reflect all translations for reasons unknown (ex: 2.3 "With this in place...")
CoinEZ-JPN added a commit to CoinEZ-JPN/comprehensive-rust that referenced this issue May 30, 2023
localhost does not reflect all translations for reasons unknown (ex: 2.3 "With this in place...")
@mgeisler
Copy link
Collaborator Author

Hi, I've read your misc-jp post and would love to contribute to this as a native Japanese speaker :) Do we already have the spreadsheet for the JA project? Or should I make one?

#652 (comment)

Hey @kantasv, amazing, welcome onboard! Thank you very much for offering to help 😄

Please coordinate with @CoinEZ-JPN and @keiichiw about using a spreadsheet. It might not be necessary if it's just you and @CoinEZ-JPN who are actively working on the translation.

@CoinEZ-JPN
Copy link
Contributor

@keiichiw hi thanks instructions
Is it alright if I commit the intro (ch.1 and 2) in a single PR?
The rest I will separate into its own branch.

@kantasv apol missed, not aware of what misc-jp is, but would be nice to work together - what do you need me to do?

@HidenoriKobayashi
Copy link
Collaborator

Hi, @HidenoriKobayashi -san. The Poedit behaviors you mentioned weren't reproducible in my environment:

  • My Poedit version: 3.51, Mac OS: Sonoma 14.2.1

  • Triangle explamation icons on top of the text lists are visible:

    • Source texts do not always have explamation icons — only some but not all
    • Clicking a line with the icon shows me concrete feedback, such as 翻訳は"."で終える必要があります。

Do you still have the same issue?

Thanks @kantasv for the message! It somehow works as intended now.

@HidenoriKobayashi
Copy link
Collaborator

By the way, when the professional translations are merged, what else is left for this issue?

@henrif75
Copy link
Collaborator

By the way, when the professional translations are merged, what else is left for this issue?

There will be several translations that will need to be reviewed because they're marked as "fuzzy". Besides that, the original course is constantly updated and improved, and eventually translations need to catch up.

henrif75 added a commit that referenced this issue Mar 21, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Kanta Yamaoka (山岡幹太) <[email protected]>
@HidenoriKobayashi
Copy link
Collaborator

@henrif75 Regarding the profession translation PRs, are the comments handled by yourself or they go back to the translation team?

I had naively regarded that they will be read by someone who can read Japanese. If that is not the case, maybe I should try to convert all my comments to suggestions that you can apply. Well, that obviously takes some time, but it's doable.

@mgeisler
Copy link
Collaborator Author

By the way, when the professional translations are merged, what else is left for this issue?

There will be several translations that will need to be reviewed because they're marked as "fuzzy". Besides that, the original course is constantly updated and improved, and eventually translations need to catch up.

I agree. I also wonder if we should mark the per-language issues as closed after we publish the first version? I think it could make sense to mark that milestone.

@kantasv
Copy link
Collaborator

kantasv commented Apr 21, 2024

Hi @mgeisler , could we add @HidenoriKobayashi -san to the repo? We already added Hidenori-san to CODEOWNERS, but now I remember a comment from you:

You need write permission on the repository to review things (we enabled this after we got a few spam reviews).

(#1472 (comment))

@mgeisler
Copy link
Collaborator Author

Yes, certainly! Welcome @HidenoriKobayashi!

henrif75 added a commit that referenced this issue Apr 22, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Kanta Yamaoka (山岡幹太) <[email protected]>
henrif75 added a commit that referenced this issue May 7, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652
henrif75 added a commit that referenced this issue May 8, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Hidenori Kobayashi <[email protected]>
henrif75 added a commit that referenced this issue May 28, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Hidenori Kobayashi <[email protected]>
henrif75 added a commit that referenced this issue May 28, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Hidenori Kobayashi <[email protected]>
henrif75 added a commit that referenced this issue May 31, 2024
This PR merges the Japanese (ja) v.2 translation back to main.
This requires just a syntactical review, as the partial PRs into this
branch were reviewed already.

You can skim this PR with the [GitHub CLI](https://cli.github.com/):

gh pr diff 2103 | bat -l patch

#1463 #652

---------

Co-authored-by: Kanta Yamaoka (山岡幹太) <[email protected]>
Co-authored-by: Hidenori Kobayashi <[email protected]>
henrif75 added a commit that referenced this issue Jun 20, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Hidenori Kobayashi <[email protected]>
henrif75 added a commit that referenced this issue Jul 5, 2024
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Japanese content
is reviewed.

#1463 #652

---------

Co-authored-by: Hidenori Kobayashi <[email protected]>
@HidenoriKobayashi
Copy link
Collaborator

Now that the professional translation PRs went in (thanks @henrif75!), I think we can close this issue to mark that milestone. Although I see many parts that are behind the English main version, I think those should be easier managed if we handle them separately from this one.

What I'd like to do after this is that we create an issue to catch-up with the English main version every quarter or so. Plus, if there's something wrong, we create a specific issue and correct that.

Does anyone have an objection? (If so, please re-open this issue)

@mgeisler
Copy link
Collaborator Author

mgeisler commented Jul 9, 2024

What I'd like to do after this is that we create an issue to catch-up with the English main version every quarter or so. Plus, if there's something wrong, we create a specific issue and correct that.

That sounds like a great idea, thanks @HidenoriKobayashi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants