-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Japanese translation #652
Comments
ja: tooling check (google#652)
Start working on google#652
ja: Create initial ja.po file Start working on #652
translation of just the Table of Contents google#652
Hey @momotaro1105, @keiichiw, @CoinEZ-JPN and other people interested in the Japanese translation. Just a small note: I've created spreadsheets to help organize some of the other translations, see #684 for an example. That might be useful for you too. |
Hi, I've read your post and would love to contribute to this as a native Japanese speaker :) |
localhost does not reflect all translations for reasons unknown (ex: 2.3 "With this in place...")
adding spacing consistency after `:` for table of contents
* ja: tooling check (#652) * updating table of contents based on suggestions --------- Co-authored-by: Kenta Aratani <[email protected]>
err-ing on 構文 over 文法, but open to advice
hello, just checking - the next PR should come directly from my branch post fetch origin, correct? |
@CoinEZ-JPN If the branch on your forked repository is based on this repository's main branch and your commit message includes Note that it would be easier if one pull request translates only one chapter. That's said it'd be nice if you have branches such as |
localhost does not reflect all translations for reasons unknown (ex: 2.3 "With this in place...")
localhost does not reflect all translations for reasons unknown (ex: 2.3 "With this in place...")
localhost does not reflect all translations for reasons unknown (ex: 2.3 "With this in place...")
Hey @kantasv, amazing, welcome onboard! Thank you very much for offering to help 😄 Please coordinate with @CoinEZ-JPN and @keiichiw about using a spreadsheet. It might not be necessary if it's just you and @CoinEZ-JPN who are actively working on the translation. |
Thanks @kantasv for the message! It somehow works as intended now. |
By the way, when the professional translations are merged, what else is left for this issue? |
There will be several translations that will need to be reviewed because they're marked as "fuzzy". Besides that, the original course is constantly updated and improved, and eventually translations need to catch up. |
Professional translations for CR2 content. Changes are being staged in a separate branch until all Japanese content is reviewed. #1463 #652 --------- Co-authored-by: Kanta Yamaoka (山岡幹太) <[email protected]>
@henrif75 Regarding the profession translation PRs, are the comments handled by yourself or they go back to the translation team? I had naively regarded that they will be read by someone who can read Japanese. If that is not the case, maybe I should try to convert all my comments to suggestions that you can apply. Well, that obviously takes some time, but it's doable. |
I agree. I also wonder if we should mark the per-language issues as closed after we publish the first version? I think it could make sense to mark that milestone. |
Hi @mgeisler , could we add @HidenoriKobayashi -san to the repo? We already added Hidenori-san to CODEOWNERS, but now I remember a comment from you:
|
Yes, certainly! Welcome @HidenoriKobayashi! |
Professional translations for CR2 content. Changes are being staged in a separate branch until all Japanese content is reviewed. #1463 #652 --------- Co-authored-by: Kanta Yamaoka (山岡幹太) <[email protected]>
Professional translations for CR2 content. Changes are being staged in a separate branch until all Japanese content is reviewed. #1463 #652 --------- Co-authored-by: Hidenori Kobayashi <[email protected]>
Professional translations for CR2 content. Changes are being staged in a separate branch until all Japanese content is reviewed. #1463 #652 --------- Co-authored-by: Hidenori Kobayashi <[email protected]>
Professional translations for CR2 content. Changes are being staged in a separate branch until all Japanese content is reviewed. #1463 #652 --------- Co-authored-by: Hidenori Kobayashi <[email protected]>
This PR merges the Japanese (ja) v.2 translation back to main. This requires just a syntactical review, as the partial PRs into this branch were reviewed already. You can skim this PR with the [GitHub CLI](https://cli.github.com/): gh pr diff 2103 | bat -l patch #1463 #652 --------- Co-authored-by: Kanta Yamaoka (山岡幹太) <[email protected]> Co-authored-by: Hidenori Kobayashi <[email protected]>
Professional translations for CR2 content. Changes are being staged in a separate branch until all Japanese content is reviewed. #1463 #652 --------- Co-authored-by: Hidenori Kobayashi <[email protected]>
Professional translations for CR2 content. Changes are being staged in a separate branch until all Japanese content is reviewed. #1463 #652 --------- Co-authored-by: Hidenori Kobayashi <[email protected]>
Now that the professional translation PRs went in (thanks @henrif75!), I think we can close this issue to mark that milestone. Although I see many parts that are behind the English main version, I think those should be easier managed if we handle them separately from this one. What I'd like to do after this is that we create an issue to catch-up with the English main version every quarter or so. Plus, if there's something wrong, we create a specific issue and correct that. Does anyone have an objection? (If so, please re-open this issue) |
That sounds like a great idea, thanks @HidenoriKobayashi! |
The Rust Book has been translated into Japanese. Let us see if we can reuse some of their terminology.
The text was updated successfully, but these errors were encountered: