Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ko: cr2 Day 4 translations #1648

Merged
merged 6 commits into from
Feb 21, 2024
Merged

Conversation

henrif75
Copy link
Collaborator

@henrif75 henrif75 commented Jan 4, 2024

#262 #1463
Stats
Before: 1297 translated messages, 383 fuzzy translations, 1780 untranslated messages.
After: 1492 translated messages, 516 fuzzy translations, 1452 untranslated messages.

@henrif75
Copy link
Collaborator Author

henrif75 commented Jan 7, 2024

Stats after clean-up:
1490 translated messages, 396 fuzzy translations, 1574 untranslated messages.

@namhyung
Copy link
Collaborator

Please convert incorrect ' to \" in the code strings.

@henrif75 henrif75 requested a review from namhyung February 16, 2024 01:15
po/ko.po Show resolved Hide resolved
po/ko.po Show resolved Hide resolved
Copy link
Collaborator

@namhyung namhyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the module exercise is outdated.

po/ko.po Show resolved Hide resolved
po/ko.po Show resolved Hide resolved
po/ko.po Show resolved Hide resolved
po/ko.po Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
@henrif75 henrif75 requested a review from namhyung February 20, 2024 22:49
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Show resolved Hide resolved
po/ko.po Show resolved Hide resolved
po/ko.po Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
po/ko.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@jiyongp jiyongp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some inline suggestions.

@henrif75 henrif75 requested review from namhyung and jiyongp February 21, 2024 07:40
@henrif75
Copy link
Collaborator Author

Thank you!

@henrif75 henrif75 merged commit 9607392 into google:ko-v2-update Feb 21, 2024
32 checks passed
@henrif75 henrif75 deleted the ko-cr2-day4 branch February 21, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants