Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google.golang.org/grpc: move protoc-gen-go-grpc into grpc module #903

Closed
dsnet opened this issue Jul 16, 2019 · 7 comments
Closed

google.golang.org/grpc: move protoc-gen-go-grpc into grpc module #903

dsnet opened this issue Jul 16, 2019 · 7 comments

Comments

@dsnet
Copy link
Member

dsnet commented Jul 16, 2019

We intend to hand off ownership of protoc-gen-go-grpc to the google.golang.org/grpc project. This issue tracks coordination between google.golang.org/protobuf and google.golang.org/grpc to accomplish this.
@dsnet dsnet changed the title APIv2: release coordination with gRPC APIv2: release coordination with google.golang.org/grpc Jul 16, 2019
@dsnet dsnet added this to the v2 release milestone Aug 21, 2019
@dsnet
Copy link
Member Author

dsnet commented Sep 7, 2019

Note to self: we need to port the unimplemented server types to the new implementation.

mewmew added a commit to lapsang-boys/pippi that referenced this issue Oct 8, 2019
@mewmew
proto: use v2 of Protobuf
c45047c 
The CI system has not yet been update to download
the needed tools for protobuf v2 generation, these
are:

   go get -u google.golang.org/protobuf/cmd/protoc-gen-go
   go get -u google.golang.org/protobuf/cmd/protoc-gen-go-grpc

Note: protoc-gen-go-grpc will move to google.golang.org/grpc
in the future (see golang/protobuf#903).

Tentative fix of #10.
This was referenced Oct 8, 2019
Closed
Draft
mewmew added a commit to lapsang-boys/pippi that referenced this issue Oct 8, 2019
@mewmew
proto: use v2 of Protobuf
ec55bc7 
The CI system has not yet been update to download
the needed tools for protobuf v2 generation, these
are:

   go get -u google.golang.org/protobuf/cmd/protoc-gen-go
   go get -u google.golang.org/protobuf/cmd/protoc-gen-go-grpc

Note: protoc-gen-go-grpc will move to google.golang.org/grpc
in the future (see golang/protobuf#903).

Tentative fix of #10.
mewmew added a commit to lapsang-boys/pippi that referenced this issue Oct 8, 2019
@mewmew
proto: use v2 of Protobuf
2826a9a 
The CI system has not yet been update to download
the needed tools for protobuf v2 generation, these
are:

   go get -u google.golang.org/protobuf/cmd/protoc-gen-go
   go get -u google.golang.org/protobuf/cmd/protoc-gen-go-grpc

Note: protoc-gen-go-grpc will move to google.golang.org/grpc
in the future (see golang/protobuf#903).

Tentative fix of #10.
mewmew added a commit to lapsang-boys/pippi that referenced this issue Oct 8, 2019
@mewmew
proto: use v2 of Protobuf
2baf7d9 
The CI system has not yet been update to download
the needed tools for protobuf v2 generation, these
are:

   go get -u google.golang.org/protobuf/cmd/protoc-gen-go
   go get -u google.golang.org/protobuf/cmd/protoc-gen-go-grpc

Note: protoc-gen-go-grpc will move to google.golang.org/grpc
in the future (see golang/protobuf#903).

Tentative fix of #10.
@dsnet
Copy link
Member Author

dsnet commented Feb 11, 2020

This still needs to happen, but probably after the first rc1 release.

@dsnet
Copy link
Member Author

dsnet commented Feb 21, 2020

The logic has been moved to be an internal package of v1. Moving to grpc can happen shortly after but doesnt block release.

@dsnet dsnet added post-v2 and removed blocks-v2 labels Feb 21, 2020
@neild neild changed the title APIv2: release coordination with google.golang.org/grpc google.golang.org/grpc: move protoc-gen-go-grpc into grpc module Mar 3, 2020
@dsnet dsnet removed this from the v2 release milestone Mar 4, 2020
@pjediny
Copy link

pjediny commented Mar 4, 2020

Did I miss this in the release notes? I wanted to try new v2 protobuf implementation today, but cannot because of the missing protoc-gen-go-grpc. Is there any ETA for the generator in the google.golang.org/grpc module?

@neild
Copy link
Contributor

neild commented Mar 4, 2020

Adding a generator to the gRPC module is in progress; for now, you can use github.com/golang/protobuf/protoc-gen-go at version v1.4.0-rc.2 or later, which includes an integrated version of the gRPC generator as before.

@dsnet
Copy link
Member Author

dsnet commented Mar 9, 2020

The current error message produced by protoc-gen-go is unhelpful for users since protoc-gen-go-grpc doesn't exist yet.

We should update that message to point to the updated gRPC documentation when it's ready.

\cc @Merovius

@dsnet dsnet mentioned this issue Apr 2, 2020
Closed
This was referenced Apr 16, 2020
Merged
Closed
@dsnet dsnet mentioned this issue Apr 23, 2020
Closed
@dsnet
Copy link
Member Author

dsnet commented May 27, 2020

Done with grpc/grpc-go#3453

@dsnet dsnet closed this as completed May 27, 2020
@dsnet dsnet removed the post-release label Jun 1, 2020
@figroc figroc mentioned this issue Jul 13, 2020
Closed
blanquicet added a commit to inspektor-gadget/inspektor-gadget that referenced this issue Aug 11, 2021
@blanquicet
api/gadgettracermanager: Support new protoc-gen-go-grpc
e91325d 
As described in [1], plugins=grpc is not supported anymore in latest
versions of protoc-gen-go because it was moved to
https://github.com/grpc/grpc-go project [2].

This commit updates api/gadgettracermanager to use the new syntax and
regenerates the code.

[1] golang/protobuf#1070
[2] golang/protobuf#903
@blanquicet blanquicet mentioned this issue Aug 11, 2021
Merged
1 task
blanquicet added a commit to inspektor-gadget/inspektor-gadget that referenced this issue Aug 11, 2021
@blanquicet
api/gadgettracermanager: Support new protoc-gen-go-grpc
8fbc1f1 
As described in [1], plugins=grpc is not supported anymore in latest
versions of protoc-gen-go because it was moved to
https://github.com/grpc/grpc-go project [2].

This commit updates api/gadgettracermanager to use the new syntax and
regenerates the code.

[1] golang/protobuf#1070
[2] golang/protobuf#903
blanquicet added a commit to inspektor-gadget/inspektor-gadget that referenced this issue Aug 11, 2021
@blanquicet
api/gadgettracermanager: Support new protoc-gen-go-grpc
fc7c65d 
As described in [1], plugins=grpc is not supported anymore in latest
versions of protoc-gen-go because it was moved to
https://github.com/grpc/grpc-go project [2].

This commit updates api/gadgettracermanager to use the new syntax and
regenerates the code.

[1] golang/protobuf#1070
[2] golang/protobuf#903
alban pushed a commit to inspektor-gadget/inspektor-gadget that referenced this issue Aug 11, 2021
@blanquicet @alban
api/gadgettracermanager: Support new protoc-gen-go-grpc
f8152dc 
As described in [1], plugins=grpc is not supported anymore in latest
versions of protoc-gen-go because it was moved to
https://github.com/grpc/grpc-go project [2].

This commit updates api/gadgettracermanager to use the new syntax and
regenerates the code.

[1] golang/protobuf#1070
[2] golang/protobuf#903
eiffel-fl pushed a commit to eiffel-fl/inspektor-gadget that referenced this issue Aug 22, 2021
@blanquicet @eiffel-fl
api/gadgettracermanager: Support new protoc-gen-go-grpc
6142116 
As described in [1], plugins=grpc is not supported anymore in latest
versions of protoc-gen-go because it was moved to
https://github.com/grpc/grpc-go project [2].

This commit updates api/gadgettracermanager to use the new syntax and
regenerates the code.

[1] golang/protobuf#1070
[2] golang/protobuf#903
margamanterola pushed a commit to inspektor-gadget/inspektor-gadget that referenced this issue Sep 15, 2021
@blanquicet
api/gadgettracermanager: Support new protoc-gen-go-grpc
5b546a2 
As described in [1], plugins=grpc is not supported anymore in latest
versions of protoc-gen-go because it was moved to
https://github.com/grpc/grpc-go project [2].

This commit updates api/gadgettracermanager to use the new syntax and
regenerates the code.

[1] golang/protobuf#1070
[2] golang/protobuf#903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neild @dsnet @pjediny