-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proto: use v2 of Protobuf #46
Draft
mewmew
wants to merge
1
commit into
master
Choose a base branch
from
protobuf-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mewmew
force-pushed
the
protobuf-v2
branch
2 times, most recently
from
October 8, 2019 21:06
ec55bc7
to
2826a9a
Compare
The CI system has not yet been update to download the needed tools for protobuf v2 generation, these are: go get -u google.golang.org/protobuf/cmd/protoc-gen-go go get -u google.golang.org/protobuf/cmd/protoc-gen-go-grpc Note: protoc-gen-go-grpc will move to google.golang.org/grpc in the future (see golang/protobuf#903). Tentative fix of #10.
Looks like protobuf v2 is not yet ready for prime time: After clicking on bin ID Backend output:
Frontend output:
|
Let's revisit this one protobuf v2 matures a bit; tracked upstream by the protobuf v2 release milestone. |
Sounds good! There's a limit to how much a man can bleed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI system has not yet been update to download
the needed tools for protobuf v2 generation, these
are:
go get -u google.golang.org/protobuf/cmd/protoc-gen-go
go get -u google.golang.org/protobuf/cmd/protoc-gen-go-grpc
Note: protoc-gen-go-grpc will move to google.golang.org/grpc
in the future (see golang/protobuf#903).
Tentative fix of #10.