-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins are not supported : grpc #1070
Comments
The The |
@neild, thanks for update. Could you provide very approximate date for gRPC support in |
The practical effect is that when using this generator you will need to specify two flags on the protoc --go_out=. --go-grpc_out=. foo.proto The original |
Ok, this is better approach, I agree. I will rephrase my question though: could you provide very approximate date when |
Whenever grpc/grpc-go#3453 is approved and merged; unfortunately, the timing of that isn't under my control, so I can't give even an approximate date. It's in the gRPC folks' hands right now, but current events have everyone working at reduced capacity and I don't know where this is on their priority list. |
Thanks @neild. I am super excited about V2. Great job! |
I'm going to close this issue, since it seems to be a duplicate of #903 |
This doc needs to be updated. |
I recommend filing an issue on https://github.com/grpc/grpc-go/issues |
It seems strange to give a warning and recommend using a plugin that does not yet exist. |
How to use original |
See golang/protobuf#1070 Signed-off-by: Alexey Palazhchenko <[email protected]>
See golang/protobuf#1070 Signed-off-by: Alexey Palazhchenko <[email protected]>
See golang/protobuf#1070 Signed-off-by: Alexey Palazhchenko <[email protected]>
There has been a change in the protoc binary from version v1.12. For more information refer to: golang/protobuf#1070. This Makefile has been kept minimal to achieve the following: 1. Changes should be made to the replication.proto file in the root of the repo. 2. The generated code is split into two files now, lib/go/replication.pb.go and lib/go/replication_grpc.pb.go TODO: Add validation methods to ensure that the generated files match with the commited files. Signed-off-by: Raghavendra Talur <[email protected]>
See golang/protobuf#1070 Signed-off-by: Alexey Palazhchenko <[email protected]>
@AndresHMosqueda this should work: |
gRPC generation is no longer handled as a plugin of this It tells you what you need to do:
|
This can work. Great |
See golang/protobuf#1070 Signed-off-by: Alexey Palazhchenko <[email protected]>
See golang/protobuf#1070 Signed-off-by: Alexey Palazhchenko <[email protected]>
How do I use custom plugins with this change? We used to rely on that to generate custom gRPC implementation and a few additional code using our own custom plugins. Also, why was this change introduced as a minor version change when it is breaking backward compatibility? |
It was not.
|
@neild reason for stating this as as a minor version change is that in This did break our internal code generation scripts as they relied on the |
There has never been a way to add a custom plugin to The removed support you link to is in an executable (package main), not an importable package. |
As described in [1], plugins=grpc is not supported anymore in latest versions of protoc-gen-go because it was moved to https://github.com/grpc/grpc-go project [2]. This commit updates api/gadgettracermanager to use the new syntax and regenerates the code. [1] golang/protobuf#1070 [2] golang/protobuf#903
As described in [1], plugins=grpc is not supported anymore in latest versions of protoc-gen-go because it was moved to https://github.com/grpc/grpc-go project [2]. This commit updates api/gadgettracermanager to use the new syntax and regenerates the code. [1] golang/protobuf#1070 [2] golang/protobuf#903
As described in [1], plugins=grpc is not supported anymore in latest versions of protoc-gen-go because it was moved to https://github.com/grpc/grpc-go project [2]. This commit updates api/gadgettracermanager to use the new syntax and regenerates the code. [1] golang/protobuf#1070 [2] golang/protobuf#903
As described in [1], plugins=grpc is not supported anymore in latest versions of protoc-gen-go because it was moved to https://github.com/grpc/grpc-go project [2]. This commit updates api/gadgettracermanager to use the new syntax and regenerates the code. [1] golang/protobuf#1070 [2] golang/protobuf#903
As described in [1], plugins=grpc is not supported anymore in latest versions of protoc-gen-go because it was moved to https://github.com/grpc/grpc-go project [2]. This commit updates api/gadgettracermanager to use the new syntax and regenerates the code. [1] golang/protobuf#1070 [2] golang/protobuf#903
As described in [1], plugins=grpc is not supported anymore in latest versions of protoc-gen-go because it was moved to https://github.com/grpc/grpc-go project [2]. This commit updates api/gadgettracermanager to use the new syntax and regenerates the code. [1] golang/protobuf#1070 [2] golang/protobuf#903
Fix a nil pointer issue after bumping up to go1.22 More details see golang/go#65637 Also update the way protoc is called, more details see: golang/protobuf#1070 Signed-off-by: Daniel Jiang <[email protected]>
Fix a nil pointer issue after bumping up to go1.22 More details see golang/go#65637 Also update the way protoc is called, more details see: golang/protobuf#1070 Signed-off-by: Daniel Jiang <[email protected]>
run:
output:
The text was updated successfully, but these errors were encountered: