Add Makefile #5
Closed
Add Makefile #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There has been a change in the protoc binary from version v1.12. For more information refer to: golang/protobuf#1070. This Makefile has been kept minimal to achieve the following: 1. Changes should be made to the replication.proto file in the root of the repo. 2. The generated code is split into two files now, lib/go/replication.pb.go and lib/go/replication_grpc.pb.go TODO: Add validation methods to ensure that the generated files match with the commited files. Signed-off-by: Raghavendra Talur <[email protected]>
Madhu-1
reviewed
Feb 9, 2021
iamniting
suggested changes
Feb 9, 2021
| @@ -0,0 +1,6 @@ | |||
| all: build | |||
There was a problem hiding this comment.
I guess we should make sure that we have all dependencies as well if not download them.
|
Obsolete. Refer to #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a change in the protoc binary from version v1.12. For
more information refer to:
golang/protobuf#1070.
This Makefile has been kept minimal to achieve the following:
the repo.
lib/go/replication.pb.go and lib/go/replication_grpc.pb.go
TODO: Add validation methods to ensure that the generated files match
with the commited files.
Signed-off-by: Raghavendra Talur [email protected]