Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

Migrate to Go protobuf API v2 #20

Closed
2 tasks done
marcellanz opened this issue Apr 18, 2020 · 3 comments · Fixed by #51
Closed
2 tasks done

Migrate to Go protobuf API v2 #20

marcellanz opened this issue Apr 18, 2020 · 3 comments · Fixed by #51
Assignees
Labels
area/user-platform Issues related to the different user target platforms needs investigation

Comments

@marcellanz
Copy link
Contributor

marcellanz commented Apr 18, 2020

The protobuf apiv2 has been released a few weeks ago. The protbuf project supports the apiv1 indefinitely but we don't have any obligations to do so explicitly.

refs:

tasks:

  • bump to 1.4 legacy
  • check any possible impacts for users apiv1
@marcellanz marcellanz added the area/user-platform Issues related to the different user target platforms label Apr 18, 2020
@marcellanz marcellanz added this to the v0.2.0 milestone Apr 18, 2020
@marcellanz
Copy link
Contributor Author

Issues
gRPC plugin: Currently the APIv2 grpc-go plugin for the protoc compiler cannot be used to generate service stubs:
golang/protobuf#903

The grpc part of the generator is in the phase to be moved to the grpc-go project:
grpc/grpc-go#3453
and as soon as its available can be used with APIv2 to gRPC services.

Non-Issues
mixing APIv1/APIv2: is possible since github.com/golang/protobuf v1.4.0 where v1.4.0 is a shim over APIv1.

@marcellanz marcellanz self-assigned this Apr 21, 2020
@marcellanz marcellanz removed this from the Go Support v0.2.0 milestone Sep 7, 2020
@marcellanz
Copy link
Contributor Author

a discussion about how to go (or not) forward with the new protoc plugin:
grpc/grpc-go#3669

@marcellanz marcellanz changed the title migrate to protobuf-apiv2 Migrate to protobuf-apiv2 Oct 9, 2020
@marcellanz
Copy link
Contributor Author

marcellanz commented Oct 24, 2020

After we changed from the v1 API with the v2 implementation, the following WIP branch uses the new protoc-gen-go-grpcand protoc-go protoc plugins. They now produce separate pb.go and grpc.pb.go files:

https://github.com/marcellanz/go-support/tree/feature/crdt_support_protobuf_v2

@marcellanz marcellanz changed the title Migrate to protobuf-apiv2 Migrate to Go protobuf API v2 Oct 25, 2020
@marcellanz marcellanz added this to the Go Support v0.2.x milestone Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/user-platform Issues related to the different user target platforms needs investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant