Removed _change_notify(property) #45879
Conversation
reduz
commented
Feb 10, 2021
reduz
commented
- For inspector refresh, the inspector now detects if a property change by polling a few times per second and then does update the control if so. This process is very cheap.
- For property list refresh, a new signal (property_list_changed) was added to Object. _change_notify() is replaced by notify_property_list_changed()
- Changed all objects using the old method to the signal, or just deleted the calls to _change_notify() since they are unnecessary now.
| @@ -49,11 +49,7 @@ Variant ArrayPropertyEdit::get_array() const { | |||
| } | |||
|
|
|||
| void ArrayPropertyEdit::_notif_change() { | |||
There was a problem hiding this comment.
It's not necessarily to do in this PR, but I guess we could remove _notif_change here and in DictionaryPropertyEdit and use notify_property_list_changed directly in the UndoRedo code which currently uses _notif_change.
There was a problem hiding this comment.
I am not sure if these classes are still in use, i have the feeling they are not. Probably in another PR they should be removed.
There was a problem hiding this comment.
Since now there are EditorProperty based editor for arrays and dictionaries.
| E->get()->update_property(); | ||
| E->get()->update_reload_status(); | ||
| E->get()->update_cache(); |
There was a problem hiding this comment.
If those three are always called together, I guess there could be a helper method to call the three of them?
There was a problem hiding this comment.
I think properties call them from within some times or its editors.
-For inspector refresh, the inspector now detects if a property change by polling a few times per second and then does update the control if so. This process is very cheap. -For property list refresh, a new signal (property_list_changed) was added to Object. _change_notify() is replaced by notify_property_list_changed() -Changed all objects using the old method to the signal, or just deleted the calls to _change_notify(<property>) since they are unnecesary now.
reduz
force-pushed
the
remove-change-notify
branch
from
49399a8 to
1aa2823
Compare
