Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing nodes' group through Groups Editor doesn't trigger update, and causes error #50758

Closed
foxydevloper opened this issue Jul 23, 2021 · 2 comments

Comments

@foxydevloper
Copy link
Contributor

Godot version

v4.0.dev.custom_build [5156703]

System information

Windows 10

Issue description

When using the Groups Editor that's opened from the "Manage Groups" button, adding or removing nodes from groups causes the node to properly change group, but it doesn't cause an update to trigger in the Groups Editor. It also causes an error to appear in the console. You need to click on the group again in the "Groups" column for it to update.

Error: core\object\undo_redo.cpp:310 - Error calling method from signal '_group_selected': 'GroupDialog::_group_selected': Method not found.

2021-07-22_19-54-23.mp4

This bug does not occur in 3.3.2.stable, or the latest 3.x (v3.4.beta.custom_build [b856841])

Steps to reproduce

  • Have a node that's added to a group
  • Open up the "Manage Groups" dialog
  • Remove the node from the group
  • It won't immediately update until you click on the group again, and it'll show an error in the console

Minimal reproduction project

any project with nodes with groups

@Calinou
Copy link
Member

Calinou commented Jul 23, 2021

This may be due to the inspector no longer using _change_notify() in master and relying on polling instead.

@KoBeWi
Copy link
Member

KoBeWi commented May 24, 2022

Fixed.

@KoBeWi KoBeWi closed this as completed May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants