Watch for edited resources in editor

[supagu]

So I am writing a C++ plugin for godot. The user assigns a material to my custom Spatial node. Now I want to be notified when this material is changed in the editor.

It seems the add_change_receptor API nor the CoreStringNames::get_singleton()->changed signal are emitted when say the materials albedo colour changes for example.
So my next avenue was to try to connect to the property editor "variant_changed" signal, but there seems to be no way to determine what object the Property editor is editing.

I would like some way to watch when the material is modified.

[ghost]

For change_receptors to work, the Resource must call _change_notify(string) when it's changed. See TileSet for example.

godot/scene/resources/tile_set.cpp

Line 310 in 0ee72fb

_change_notify("texture");

[supagu]

yes, the material does not call this which i would expect when the colour is changed.

[Zylann]

I would like materials to give me this information too when they change, especially ShaderMaterials with custom properties, because currently for design reasons I am forced to update internal materials of my plugin every frame in the editor, which is costy (I use ShaderMaterial as a container for user-defined shader constants, since my plugin abstracts a complex set of shaders).
My only alternative is to write a completely custom set of properties that is identical to what you see in ShaderMaterial, AND write an editor for them (from scratch!)

[akien-mga]

For the reference, the idea for 4.0 is to drop the change receptor API which is pretty hacky, and instead make the Inspector poll for changes constantly (which could then be notified to the EditorInterface/EditorInspector API I guess for plugin use).

14:36 <reduz> Akien: the change receptor API needs to go away
14:36 <reduz> and the inspector needs to constantly poll for changes
14:37 <reduz> this will simplify things enormously, the problem is that when I tried to do it, I found we merged plenty of PRs of contributors hacking the change receptors for other things not the inspector that will need to be rewritten in a different way and it was quite some work
14:37 <reduz> so I never got around to fix this
14:37 <reduz> it has been a problem for a long time now

[Calinou]

_change_notify() was removed in master. For plugins, Object now has a property_list_changed signal which can be used for this purpose.

[Zylann]

@Calinou I'm not sure it relates to this issue. property_list_changed and _change_notify was for notifying the inspector that the object's properties changed.

But this issue is about the other side, where you have a reference to a resource, and want to know when it changed. The changed signal exists, but apparently is not always emitted. Alternatives exist but weren't working either in these cases. The inspector now polls for changes, but I'm not sure it is sharing this information through any API and that would only work for the inspector.

It seems the add_change_receptor API nor the CoreStringNames::get_singleton()->changed signal are emitted when say the materials albedo colour changes for example.

I would like materials to give me this information too when they change, especially ShaderMaterials with custom properties

[KoBeWi]

The changed signal exists, but apparently is not always emitted.

I think the signal should be emitted on all Resource changes. If it doesn't in some cases, it's a bug IMO.