Restore page bottom margin #7388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
release-note
team: webapp
gtsiolis
commented
Dec 29, 2021
There was a problem hiding this comment.
@jankeromnes could you take a look at this small change when you are back?
| @@ -167,7 +167,7 @@ export default function () { | |||
| </div> | |||
| <button onClick={showStartWSModal} className="ml-2">New Workspace</button> | |||
| </div> | |||
| <ItemsList className="app-container"> | |||
| <ItemsList className="app-container pb-40"> | |||
There was a problem hiding this comment.
thought: Not sure why this didn't work with margin but using padding here does the trick.
jankeromnes
approved these changes
Jan 5, 2022
|
LGTM label has been added. Git tree hash: a0af3d01bd2975b942ae28676a67c4be53d04d10
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jankeromnes Associated issue: #4634 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks, @jankeromnes! 🐈 |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the changes in #7065, this will🅰️ revert the change from #4417 and 🅱️ add some extra margin at the bottom of each page provides better UX when navigating long lists or large sections that reach the bottom of the viewport when scrolling to the end of the lists or sections.
Related Issue(s)
Fixes #4634
Screenshots
How to test
Try opening a few workspaces so that that list of worksspaces reaches the bottom of the viewport or going to user preferences on a viewport with a small height. Then, scroll down to the bottom of the page. Notice how this PR introduces some extra white space at the bottom of the page and lists or sections do not seem attached to the bottom of the viewport.
Release Notes