[dashboard] Remove margin-bottom from PageWithSubMenu

[corneliusludmann]

Avoids unnecessary scrollbars. Fixes #3859.

Before this change, pages in the settings section do have a margin at the bottom. That leads to unnecessary scrollbars:

Without the margin, the scrollbars disappear:

Is there any good reason for the margin?

(Examples are with a canvas size of 1440x1049px.)

[JanKoehnlein]

/werft run

👍 started the job as gitpod-build-clu-horizontal-scrollbar-3859.1

[jankeromnes]

Is there any good reason for the margin?

FYI I believe this was to prevent awkward scrolling behavior when there are drop-downs / context menus near the bottom of the page (where the page height / scroll position abruptly changes depending on collapsed state). I don't remember where that happened though.

[corneliusludmann]

FYI I believe this was to prevent awkward scrolling behavior when there are drop-downs / context menus near the bottom of the page (where the page height / scroll position abruptly changes depending on collapsed state). I don't remember where that happened though.

OK, thanks for the comment. So, I think we should merge this change and when the original concern occurs again, we should find a proper solution (and in doubt document the decision next to the code). What do y'all think?

[JanKoehnlein]

/werft run

👍 started the job as gitpod-build-clu-horizontal-scrollbar-3859.2

[JanKoehnlein]

LGTM