Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore some of the bottom margin on dashboard pages #4634

Closed
gtsiolis opened this issue Jun 28, 2021 · 6 comments · Fixed by #7388
Closed

Restore some of the bottom margin on dashboard pages #4634

gtsiolis opened this issue Jun 28, 2021 · 6 comments · Fixed by #7388
Assignees
Labels
component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team user experience

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Jun 28, 2021

Problem to solve

In #4417 (cc @corneliusludmann), we've removed the bottom margin on dashboard pages, however, we need to always keep some of the bottom margin (e.g. mb-16) to allow long lists Workspaces or sections like Prefereces render without touching the bottom of the viewport on small viewports.

@corneliusludmann
Copy link
Contributor

Makes sense.

Suggestion: Please document the reason for the bottom margin in the code so that we remember it for future changes.

@stale
Copy link

stale bot commented Sep 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 26, 2021
@gtsiolis gtsiolis added the meta: never-stale This issue can never become stale label Sep 27, 2021
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Sep 27, 2021
@gtsiolis
Copy link
Contributor Author

This is still relevant. Adding meta: never-stale label.

@jwpjrdev
Copy link
Contributor

jwpjrdev commented Dec 8, 2021

I might do this sometime. It's been driving me crazy for months.

@trumbitta
Copy link
Contributor

trumbitta commented Dec 18, 2021

Following the line of though of this comment from #4417 ("we should find a proper solution")

And having seen what happens at small resolutions / viewports:

image

I think reworking the whole dashboard app with a modern mobile first approach might be resolutive in regards of this and other issues that may and will arise.
The layout will be more robust, resilient, possibly more maintainable and easily extendable because mobile first has the main effect of giving you something that's good on mobile and tablets, and the side effect of giving you something that's good everywhere 😄 . It's not dissimilar from Accessibility in this: both of them make the experience better for everyone.

And hey 🖐️ I can help. I have experience in mobile first, have been advocating for it, building my web apps like this since 2011 when I read the seminal book about it, and I can work on it together with a Designer (if Gitpod has a Product Designer, this is of course the preferred way!), in a team, or alone.
I've been doing it at my daily jobs for the last 10yrs and it's just how I think about web apps.

It's not something we can do overnight in a magic little size/S PR, but step by step we can manage to pull it off.

Come find me on discord if you like the idea!

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Dec 29, 2021

Added #7388 to resolve this.

🍊 🍊 🍊 🍊

@corneliusludmann, following the comment in #4634 (comment), I've added a point about this in an internal draft I'm writing about design guidelines.

Re-posting from there:

Every part of a user interface should be intentional including the empty space between elements. The amount of space between items creates relationships and hierarchy.

Pages should be also intentional about empty space. For example, including some extra margin at the bottom of each page provides better UX when navigating long lists or large sections that reach the bottom of the viewport when scrolling to the end of the lists or sections.

@jldec jldec moved this to In Review in 🍎 WebApp Team Jan 2, 2022
Repository owner moved this from In Review to Done in 🍎 WebApp Team Jan 5, 2022
@jldec jldec moved this to Done in 🍎 WebApp Team Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team user experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants