-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore some of the bottom margin on dashboard pages #4634
Comments
Makes sense. Suggestion: Please document the reason for the bottom margin in the code so that we remember it for future changes. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is still relevant. Adding meta: never-stale label. |
I might do this sometime. It's been driving me crazy for months. |
Following the line of though of this comment from #4417 ("we should find a proper solution") And having seen what happens at small resolutions / viewports: I think reworking the whole dashboard app with a modern mobile first approach might be resolutive in regards of this and other issues that may and will arise. And hey 🖐️ I can help. I have experience in mobile first, have been advocating for it, building my web apps like this since 2011 when I read the seminal book about it, and I can work on it together with a Designer (if Gitpod has a Product Designer, this is of course the preferred way!), in a team, or alone. It's not something we can do overnight in a magic little Come find me on discord if you like the idea! |
Added #7388 to resolve this. 🍊 🍊 🍊 🍊 @corneliusludmann, following the comment in #4634 (comment), I've added a point about this in an internal draft I'm writing about design guidelines. Re-posting from there:
|
Problem to solve
In #4417 (cc @corneliusludmann), we've removed the bottom margin on dashboard pages, however, we need to always keep some of the bottom margin (e.g.
mb-16
) to allow long lists Workspaces or sections like Prefereces render without touching the bottom of the viewport on small viewports.The text was updated successfully, but these errors were encountered: