Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bottom padding for projects, branches, and prebuilds #7578

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

gtsiolis
Copy link
Contributor

Description

This will add some bottom padding for the Projects, Branches, and Prebuilds pages, following the changes in #7388.

Screenshots

BEFORE AFTER
Screenshot 2022-01-12 at 11 15 58 PM (2) Screenshot 2022-01-12 at 11 16 12 PM (2)

Release Notes

Add bottom padding for Projects, Branches, and Prebuilds pages

@roboquat roboquat added release-note team: webapp Issue belongs to the WebApp team size/XS labels Jan 12, 2022
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jan 12, 2022

@AlexTugarev could you take a look at this when you're? 🏀

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #7578 (cfb5262) into main (40d456c) will decrease coverage by 1.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #7578      +/-   ##
=========================================
- Coverage   10.81%   9.53%   -1.29%     
=========================================
  Files          20      18       -2     
  Lines        1248    1080     -168     
=========================================
- Hits          135     103      -32     
+ Misses       1110     976     -134     
+ Partials        3       1       -2     
Flag Coverage Δ
components-gitpod-cli-app 9.53% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d456c...cfb5262. Read the comment docs.

@AlexTugarev
Copy link
Member

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 98de6f3bc841cd906a2087823529f7235cf022d7

@gtsiolis
Copy link
Contributor Author

Thanks @AlexTugarev! Could you also approve this using GitHub as this is required to unblock merging?

@AlexTugarev
Copy link
Member

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev

Associated issue requirement bypassed by: AlexTugarev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 543675c into main Jan 13, 2022
@roboquat roboquat deleted the gt/add-bottom-padding branch January 13, 2022 10:46
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component: dashboard deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants