Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spacing layout for user, workspace, project, and organization in the admin dashboard #16408

Closed
gtsiolis opened this issue Feb 15, 2023 · 4 comments · Fixed by #16415
Closed
Assignees
Labels
feature: admin dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Feb 15, 2023

Problem to solve

Following up from #16307, there are a few nitpicks that fell between the cracks., besides the issue described in #16399.

  1. The page layout when visiting a workspace or a project lacks a proper width limit.
  2. The user, workspace, project, and organization could benefit from some top margin.
  3. From a discussion in the initial PR in UI updates to admin dashboard #16307 (review): There are a few minor issues like column header alignment and missing sorting icons ...

Cc @Devansu-Yadav

Project Workspace User Org
admin-project admin-workspace admin-user admin-org
@gtsiolis gtsiolis added help wanted feature: admin dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Feb 15, 2023
@Devansu-Yadav
Copy link
Contributor

Problem to solve

Following up from #16307, there are a few nitpicks that fell between the cracks., besides the issue described in #16399.

  1. The page layout when visiting a workspace or a project lacks a proper width limit.
  2. The user, workspace, project, and organization could benefit from some top margin.
  3. From a discussion in the initial PR in UI updates to admin dashboard #16307 (review): There are a few minor issues like column header alignment and missing sorting icons ...

@gtsiolis I have a clear idea of how to proceed with [1] and [2]. For [3], I'm aware of the column header alignment and missing sorting icons issue for the Users page. Any other pages that you could notice that have the same issue on the admin dashboard?

@gtsiolis
Copy link
Contributor Author

@Devansu-Yadav For [3]:

  1. Besides the Users page, the Workspaces page has an extra empty cell in front of the name.
  2. The sorting icon seems more useful only to the Users page as you mentioned above.

There are more improvements I can jot down if we go down this route, but I'd like to limit the amount of focus or energy we put in this until we can be sure the admin dashboard or its component will still be useful in the product direction. Listing of them in case any of these are trivial to fix:

@Devansu-Yadav
Copy link
Contributor

@Devansu-Yadav For [3]:

  1. Besides the Users page, the Workspaces page has an extra empty cell in front of the name.
  2. The sorting icon seems more useful only to the Users page as you mentioned above.

Sure, I'll make the appropriate changes.

There are more improvements I can jot down if we go down this route, but I'd like to limit the amount of focus or energy we put in this until we can be sure the admin dashboard or its component will still be useful in the product direction. Listing of them in case any of these are trivial to fix:

This makes sense. Maybe once we tackle this issue as well as #16399, I can probably have a look into these.

@gtsiolis
Copy link
Contributor Author

Thanks, @Devansu-Yadav! I appreciate the effort and energy you put in this. 🍊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: admin dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants