Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout for admin dashboard pages #16415

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

Devansu-Yadav
Copy link
Contributor

@Devansu-Yadav Devansu-Yadav commented Feb 15, 2023

Description

  • Fixes page layout for workspace and project pages.
  • Add top margin to user, workspace, project, and organization pages.
  • Fix column header alignment for user and workspace pages, and add missing sorting icons.

Related Issue(s)

Fixes #16408

How to test

Release Notes

Update spacing layout for user, workspace, project, and organization in the admin dashboard

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@Devansu-Yadav Devansu-Yadav requested a review from a team February 15, 2023 13:19
@werft-gitpod-dev-com
Copy link

annotations in the pull request changed, but user is not allowed to start a job

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-update-layout.0 because the annotations in the pull request description changed
(with .werft/ from main)

@gtsiolis

This comment was marked as outdated.

@gtsiolis
Copy link
Contributor

gtsiolis commented Feb 15, 2023

/werft run with-preview=true

👍 started the job as gitpod-build-update-layout-fork.0
(with .werft/ from main)

@Devansu-Yadav Devansu-Yadav marked this pull request as ready for review February 15, 2023 15:35
@gtsiolis
Copy link
Contributor

gtsiolis commented Feb 15, 2023

/werft run with-preview=true

👍 started the job as gitpod-build-update-layout-fork.1
(with .werft/ from main)

@gtsiolis
Copy link
Contributor

gtsiolis commented Feb 15, 2023

Looking at this now! 👀

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flawless, @Devansu-Yadav! 💯 🔮

@roboquat roboquat merged commit 07c65aa into gitpod-io:main Feb 15, 2023
@Devansu-Yadav Devansu-Yadav deleted the update-layout branch February 16, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update spacing layout for user, workspace, project, and organization in the admin dashboard
3 participants