Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update settings layout for the admin dashboard #16399

Closed
gtsiolis opened this issue Feb 14, 2023 · 7 comments · Fixed by #16427
Closed

Update settings layout for the admin dashboard #16399

gtsiolis opened this issue Feb 14, 2023 · 7 comments · Fixed by #16427
Assignees
Labels
feature: admin dashboard team: webapp Issue belongs to the WebApp team

Comments

@gtsiolis
Copy link
Contributor

Problem to solve

Following up from #16307 (review):

❗ issue: One UX change I find a bit jarring is the License and Settings layout, as expected since they were designs with a different layout.

Cc @Devansu-Yadav

Proposal

...
Reuse the left sidebar which is commonly used for project or org settings, to host two admin settings: General (Usage Statistics and Telemetry settings) and License, so that these pages can continue to use the previous layout.

@Devansu-Yadav
Copy link
Contributor

Problem to solve

Following up from #16307 (review):

❗ issue: One UX change I find a bit jarring is the License and Settings layout, as expected since they were designs with a different layout.

Proposal

Two approaches we can take here:

  1. Reuse the left sidebar which is commonly used for project or org settings, to host two admin settings: General (Usage Statistics and Telemetry settings) and License, so that these pages can continue to use the previous layout.
  2. Leave this as is and open a follow-up issue or PR to tackle the layout reordering for License and Settings.

@gtsiolis If we talk about the first approach i.e Reusing the left sidebar, are you suggesting having License and Settings under a single tab(called "Settings" or something appropriate) on the admin dashboard with a sub-menu that contains these two settings (General and License)?

@gtsiolis
Copy link
Contributor Author

... are you suggesting having ...

@Devansu-Yadav Exactly! Do you see any drawbacks or blind spots for this change?

@Devansu-Yadav
Copy link
Contributor

Devansu-Yadav commented Feb 15, 2023

... are you suggesting having ...

@Devansu-Yadav Exactly! Do you see any drawbacks or blind spots for this change?

@gtsiolis For now, I can't see any drawbacks as such, as I probably read that only the free community license for Gitpod is now being supported after the Nov 2022 release (please correct me if I'm wrong 😅), so it doesn't make much sense to me to keep it under a separate tab called "License". I think this change would probably help make the UX of the admin dashboard more consistent with the org dashboard.

@gtsiolis
Copy link
Contributor Author

@Devansu-Yadav Yes:

  1. Truth is we're deprecating support for self-hosted and focusing on Dedicated, our new offering, see relevant blog post.
  2. The license page will most probably be dropped all together in the near future.
  3. Also, generally the admin dashboard is still useful internally, and I would estimate that parts of it will continue to live through the new Organizations, previously known as teams (see Epic: Turn Teams into Organizations  #15980), for both Dedicated instances and Gitpod.io. 💭

@Devansu-Yadav
Copy link
Contributor

  1. The license page will most probably be dropped all together in the near future.

@gtsiolis If the License page is most likely going to be dropped, then would it be feasible to combine "Settings" and "License" under a single tab and have a sub-menu? 🤔

I'm thinking from the perspective of duplication of efforts here, since once we go ahead with a sub-menu with "General" and "License" options, we might have to go back to without the sub-menu (as the sub-menu would then only have one option i.e "General") 😅

@gtsiolis
Copy link
Contributor Author

@Devansu-Yadav:

  1. Dropping the license page has not been discussed internally with the team.
  2. I'd go for duplication as a boring (simple) solution.
  3. Going with the two tabs will also help with the visual balance or the raison d'être of the sidebar in settings.
  4. By the time we decide to drop the license tab, there could be a need for more settings that can be nested in this tab.

@Devansu-Yadav
Copy link
Contributor

  1. Dropping the license page has not been discussed internally with the team.
  2. I'd go for duplication as a boring (simple) solution.
  3. Going with the two tabs will also help with the visual balance or the raison d'être of the sidebar in settings.
  4. By the time we decide to drop the license tab, there could be a need for more settings that can be nested in this tab.

These are some really valid points! 💯
I'll make the changes then to move "License" and "Settings" under one tab and re-use the left sidebar 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: admin dashboard team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants