UX: Re-use left sub-menu for Settings and License page on admin dashboard #16427
Conversation
|
annotations in the pull request changed, but user is not allowed to start a job |
|
@gtsiolis Do we need to make the Settings and License pages on the admin dashboard mobile responsive? |
@Devansu-Yadav No, it's ok to leave these as they are for now for the following reasons:
/werft run with-preview-true 👍 started the job as gitpod-build-update-settings-layout-fork.0 |
|
/werft run with-preview=true 👍 started the job as gitpod-build-update-settings-layout-fork.1 |
Yes, it is quite responsive already, except for the Tabs component below the header, which is not that responsive due to the no of tabs present on the admin dashboard.
@gtsiolis Sure, in fact, I'd love to help out with this issue in case there haven't been any changes addressing the responsive layout for the dashboard 😄 |
| }, | ||
| { | ||
| title: "License", | ||
| link: ["/admin/license"], |
There was a problem hiding this comment.
issue: The Admin menu becomes inactive when navigating to the license page. Could we keep it active?
There was a problem hiding this comment.
Fixed it! Was just a one-liner fix that was needed 😆
Actually, I completely missed out that updating the getAdminTabs function to remove the License page route might cause such an issue, as this function is being used to set the active state on the admin menu 😅.
|
/werft run with-preview=true 👍 started the job as gitpod-build-update-settings-layout-fork.2 |
| alternatives: [ | ||
| ...getAdminTabs().reduce( | ||
| (prevEntry, currEntry) => | ||
| currEntry.alternatives | ||
| ? [...prevEntry, ...currEntry.alternatives, currEntry.link] | ||
| : [...prevEntry, currEntry.link], | ||
| [] as string[], | ||
| ), | ||
| ], |
There was a problem hiding this comment.
thought: Not sure about this piece of code here, but UX looks good. I'll loop in @gitpod-io/engineering-webapp for visibility in case this needs a revert or a different approach.
There was a problem hiding this comment.
Sure, no problem!
Basically, this code populates all the top-level admin dashboard routes obtained through the getAdminTabs function, which are then passed to the isSelected function to set the active state for the admin menu on these top-level routes. Hope this makes it a bit clear 😅
There was a problem hiding this comment.
Thanks for clarifying, @Devansu-Yadav! 🙇
Description
Related Issue(s)
Fixes #16399
How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh