Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate Admin dashboard list views without first requiring a search #8983

Open
jimmybrancaccio opened this issue Mar 28, 2022 · 10 comments · Fixed by #13161
Open

Populate Admin dashboard list views without first requiring a search #8983

jimmybrancaccio opened this issue Mar 28, 2022 · 10 comments · Fixed by #13161
Labels
feature: admin dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@jimmybrancaccio
Copy link

Is your feature request related to a problem? Please describe

Showing nothing in the Admin Dashboard on the Workspaces page has resulted in some confusion that no workspaces exist on an instance or that there's a problem with the UI or a backend process that may fetch a list of workspaces, as one expects a list of workspaces to show up when the page is loaded. At the moment this page is only populated when a search is performed. This action which must be performed manually is not clearly identified on the page.

Describe the behaviour you'd like

I'd like the page to display a list of workspaces perhaps 25 to 50 at a time in a paginated table.

Describe alternatives you've considered

None as there is no other UI in the admin dashboard which displays a listing of workspaces.

Additional context

N/A.

@axonasif axonasif added feature: admin dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Mar 30, 2022
@jldec
Copy link
Contributor

jldec commented Apr 8, 2022

This issue is generalizable across lists E.g.

  • user list could default to just your user account, or all users paginated alphabetically or choronologically sorted
  • other lists should default to showing something sensible (most recent X)

@jimmybrancaccio
Copy link
Author

@jldec I totally agree. After putting together my other feature request for the users listing, I also saw the Projects and Teams pages so this idea would also apply to them as well.

The user list should default to something sensible as well, not just you. I'm thinking all users, sorted alphabetically, paginated. Ideally that goes for workspaces, teams and projects too.

@gtsiolis
Copy link
Contributor

Usually, the most common approach would be listing with pagination most recently created entries for users, workspaces, projects, and teams. Depending on the entity (user, team, etc) we could also consider using a different default sorting filter like recently created or recently updated.

@jldec jldec changed the title Populate Workspaces Page in Admin Dashboard Populate Admin dashboard list views without first requiring a search May 3, 2022
@jldec
Copy link
Contributor

jldec commented May 25, 2022

scheduled

@jldec jldec moved this to Scheduled in 🍎 WebApp Team May 25, 2022
@svenefftinge svenefftinge self-assigned this Sep 21, 2022
@jldec jldec moved this from Scheduled to In Progress in 🍎 WebApp Team Sep 22, 2022
Repository owner moved this from In Progress to Done in 🍎 WebApp Team Sep 22, 2022
@jldec
Copy link
Contributor

jldec commented Oct 11, 2022

Reopening since the auto-search was reverted in #13569

@jldec jldec reopened this Oct 11, 2022
Repository owner moved this from Done to Scheduled in 🍎 WebApp Team Oct 11, 2022
@geropl geropl removed the status in 🍎 WebApp Team Nov 4, 2022
@svenefftinge svenefftinge moved this to In Validation in 🍎 WebApp Team Nov 15, 2022
@jimmybrancaccio
Copy link
Author

Hey @svenefftinge! Are we going to reimplement this functionality in another issue?

@svenefftinge
Copy link
Member

Sorry, I was misreading this and thought this was done already.

@svenefftinge svenefftinge reopened this Nov 15, 2022
Repository owner moved this from In Validation to Scheduled in 🍎 WebApp Team Nov 15, 2022
@svenefftinge svenefftinge removed their assignment Nov 15, 2022
@svenefftinge
Copy link
Member

FWIW: I disabled the initial search because the search is super slow on gitpod.io and worth to be avoided when not needed.

@jimmybrancaccio
Copy link
Author

jimmybrancaccio commented Nov 15, 2022

So it looks like on the Users page we just show the users name, their email address and the time their Gitpod account was created. I don't remember how many accounts we pull for the first page but pulling 50 ran in 122ms for me (querying against the gitpod.io SaaS database):

SELECT name, d_b_identity.primaryEmail, creationDate FROM d_b_user INNER JOIN d_b_identity ON d_b_user.id =  d_b_identity.userId ORDER BY creationDate DESC LIMIT 50;

This could be a 🛹 to at least show the last 50 created accounts on the page without having to run a search first.

@stale
Copy link

stale bot commented Feb 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@gtsiolis gtsiolis added the meta: never-stale This issue can never become stale label Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: admin dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants