Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin] don't run an empty search on load #13569

Merged
merged 1 commit into from
Oct 4, 2022
Merged

[admin] don't run an empty search on load #13569

merged 1 commit into from
Oct 4, 2022

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Oct 4, 2022 •
edited
Loading

Description

When navigating to the admin dashboard, we no longer automatically running an empty search on load.

Related Issue(s)

Fixes #13334

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@svenefftinge svenefftinge requested a review from a team October 4, 2022 07:50
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 4, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-sefftinge-main-admin-dashboard-13334.1 because the annotations in the pull request description changed
(with .werft/ from main)

@svenefftinge svenefftinge marked this pull request as draft October 4, 2022 07:51
@svenefftinge svenefftinge force-pushed the sefftinge/main-admin-dashboard-13334 branch from e51d829 to 3bdb0e2 Compare October 4, 2022 08:14
@roboquat roboquat added size/S and removed size/XS labels Oct 4, 2022
@svenefftinge svenefftinge changed the title [admin] don't search all users initially [admin] don't run an empty search on load Oct 4, 2022
@svenefftinge svenefftinge marked this pull request as ready for review October 4, 2022 08:16
easyCZ
easyCZ reviewed Oct 4, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead reject an empty search on the server side? Fixing this client side is all nice but we're still leaving the problematic search in there.

@svenefftinge
Copy link
Member Author

svenefftinge commented Oct 4, 2022 •
edited
Loading

Can we instead reject an empty search on the server side? Fixing this client side is all nice but we're still leaving the problematic search in there.

We want to allow empty searches.

@roboquat roboquat merged commit cf038e8 into main Oct 4, 2022
@roboquat roboquat deleted the sefftinge/main-admin-dashboard-13334 branch October 4, 2022 09:50
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 4, 2022
@jldec jldec mentioned this pull request Oct 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Main Admin Dashboard Page on SaaS Instance (/admin/users) Is Slow To Load
3 participants
@svenefftinge @easyCZ @roboquat