Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build infrastructure of replay package #6280

Closed
8 tasks done
Tracked by #5326
Lms24 opened this issue Nov 24, 2022 · 1 comment
Closed
8 tasks done
Tracked by #5326

Update build infrastructure of replay package #6280

Lms24 opened this issue Nov 24, 2022 · 1 comment
Assignees
Labels
Package: replay Issues related to the Sentry Replay SDK

Comments

@Lms24
Copy link
Member

Lms24 commented Nov 24, 2022

After merging in replay, with only minimal changes, we need to apply our monorepo's build config to the replay package.

To Do:

Risks:

Updating the tarball structure will be a breaking change for anyone who explicitly imports modules from the replay package. This is fine, as we're not yet stable and we're jumping major versions from 0.x to 7.x anyway. Also, this is an edge case scenario and definitely not something that concerns the majority of our users. More info: getsentry/sentry-replay#321

Build changes have the potential to cause bugs and issues. We'll have to be careful. Verifying the tarball contents before it is released is absolutely necessary.

ref: #5326

@Lms24
Copy link
Member Author

Lms24 commented Dec 1, 2022

Closing this as I think the high-prio items are complete for the time being. We still have a few open ToDos around Eslint and smaller build changes (version replacement mainly) but we can do this iteratively later on.

@Lms24 Lms24 closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

No branches or pull requests

1 participant