Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(replay): Adjust type declaration output directory #6353

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 30, 2022

This PR follows up with a small change on top of #6343 to further align the build directory. Previously, types were built into build/npm/types/src/index.d.ts. The src sub-directory shouldn't be in there, so this PR fixes that by removing some leftover properties in the main tsconfig.json which caused this sub-directory to appear.

This PR also removes a few additional unnecessary properties, such as types which we only need in tsconfig.test.json.

ref: #6280

@Lms24 Lms24 requested a review from mydea November 30, 2022 17:08
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.57 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.59 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.36 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.15 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.12 KB (0%)
@sentry/browser - Webpack (minified) 65.75 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.14 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.99 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.45 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.88 KB (+0.02% 🔺)
@sentry/replay index.js 37.2 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 37.17 KB (0%)
@sentry/replay - Webpack (minified) 124.99 KB (0%)

@Lms24 Lms24 merged commit 7c5aab3 into master Dec 1, 2022
@Lms24 Lms24 deleted the lms-replay-build-types branch December 1, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants