Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(replay): Add size limit entries for Replay #6288

Merged
merged 4 commits into from
Nov 24, 2022
Merged

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 24, 2022

This PR adds size limit entries for Replay. One entry for the (currently still exisiting bundle) and two more for the pacakage built with WebPack.

When comparing the size-limit results here with the results from the replay repo, the size goes up from 35 to 83KB but I'm pretty sure our result is more representative (the file already has 135 KB when inspecting it locally). My suspicion is that the size-limit action from the replay repo measures size differently, as it uses other GH actions and newer size-limit versions.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.5 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.29 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.16 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.63 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.9 KB (0%)
@sentry/browser - Webpack (minified) 65.12 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.93 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.37 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.78 KB (+0.02% 🔺)
@sentry/replay index.js 83.65 KB (added)
@sentry/replay - Webpack (gzipped + minified) 83.68 KB (added)
@sentry/replay - Webpack (minified) 272.11 KB (added)

@Lms24 Lms24 force-pushed the lms-replay-sizecheck branch from d733ff5 to 73c2893 Compare November 24, 2022 13:42
@Lms24 Lms24 marked this pull request as ready for review November 24, 2022 13:42
@Lms24 Lms24 requested review from mydea and AbhiPrasad November 24, 2022 13:42
@Lms24 Lms24 enabled auto-merge November 24, 2022 13:49
@Lms24 Lms24 disabled auto-merge November 24, 2022 13:49
@Lms24 Lms24 enabled auto-merge (squash) November 24, 2022 13:50
@Lms24 Lms24 merged commit 9193b71 into master Nov 24, 2022
@Lms24 Lms24 deleted the lms-replay-sizecheck branch November 24, 2022 14:27
Lms24 added a commit that referenced this pull request Nov 25, 2022
This PR reverts a few changes I unintentionally comitted and merged in #6288. It caused build errors which for some reasons did not our CI's "build" step to fail but caused size-check fails in https://github.com/getsentry/sentry-javascript/actions/runs/3546454900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants