Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(replay): Fix replay test tsconfig #6350

Merged
merged 1 commit into from
Nov 30, 2022
Merged

test(replay): Fix replay test tsconfig #6350

merged 1 commit into from
Nov 30, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 30, 2022

a) The comment is not allowed in a JSON file
b) The path is not correct (anymore)

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Nov 30, 2022
@mydea mydea requested a review from Lms24 November 30, 2022 16:14
@mydea mydea self-assigned this Nov 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.57 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.59 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.36 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.15 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.12 KB (0%)
@sentry/browser - Webpack (minified) 65.75 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.14 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.99 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.44 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.88 KB (+0.02% 🔺)
@sentry/replay index.js 37.2 KB (-40.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.17 KB (-40.05% 🔽)
@sentry/replay - Webpack (minified) 124.99 KB (-37.31% 🔽)

@mydea
test(replay): Fix replay test tsconfig
a2c77b6 
The path is not correct (anymore)
@mydea mydea force-pushed the fn/fix-replay-tsconfig branch from cfe4f82 to a2c77b6 Compare November 30, 2022 16:29
Lms24
Lms24 reviewed Nov 30, 2022
View reviewed changes
packages/replay/test/tsconfig.json
@@ -1,6 +1,5 @@
// TODO Once https://github.com/microsoft/TypeScript/issues/33094 is done (if it ever is), this file can disappear, as
// it's purely a placeholder to satisfy VSCode.

{
"extends": "../tsconfig.test.json",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path should be updated, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! Actually, I also moved the whole file up to /test (instead of /test/unit), makes more sense IMHO!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, sounds good to me 👍

@Lms24 Lms24 mentioned this pull request Nov 30, 2022
Closed
8 tasks
@mydea mydea merged commit d9c82b8 into master Nov 30, 2022
@mydea mydea deleted the fn/fix-replay-tsconfig branch November 30, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @Lms24