Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(replay): Use and extend monorepo's .eslintrc.js config #6302

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 25, 2022

Use and extend the monorepo's eslint config in Replay's eslintrc.js. The config still contains a lot of overrides for temporarily disabled rules and replay-specific settings but we'll try to reduce these as we progress.
(Doing this now because it's one less thing to worry about while I'm trying to consolidate the tsconfigs)

ref: #6280

@Lms24 Lms24 requested a review from mydea November 25, 2022 10:44
@Lms24 Lms24 marked this pull request as ready for review November 25, 2022 10:44
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.53 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.42 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.21 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.77 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.94 KB (0%)
@sentry/browser - Webpack (minified) 65.25 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.96 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.96 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.41 KB (-0.02% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.83 KB (+0.01% 🔺)
@sentry/replay index.js 83.67 KB (-0.07% 🔽)
@sentry/replay - Webpack (gzipped + minified) 83.69 KB (-0.07% 🔽)
@sentry/replay - Webpack (minified) 272.17 KB (-0.06% 🔽)

@Lms24 Lms24 enabled auto-merge (squash) November 25, 2022 11:00
@Lms24 Lms24 merged commit 3b7ce16 into master Nov 25, 2022
@Lms24 Lms24 deleted the lms-replay-eslint-global-config branch November 25, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants