-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps for Dome: use msgs6 #149
Conversation
751754c
to
79e93f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to merge CI first. Also, be sure to sign all commits 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about updating .gitbug/workflows/ci-bionic.yaml
? Otherwise I think CI will break.
Should we also remove |
e31f0d3
to
7ac677c
Compare
I would like to avoid the duplication of build-from-source dependencies (we already do that in release-tools) since it adds a good amount of overhead to manage changes in all the repositories, at least until we have a common solution in place. We can discuss this within the project, it is a structural problem of having CI code in many different places.
We are still using it to determine the platform to build branches. That functionality needs to be migrated first. |
Pending CI fixes:
|
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
4226943
to
872d8ac
Compare
Github actions are reporting green although it is a false positive, related to gazebo-tooling/action-gz-ci#11. In order to make it work properly with nightlies we need gazebo-tooling/action-gz-ci#12 and change this repo to use |
@osrf-jenkins run tests please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Jenkins CI is passing. OSX has 1 test failure and OSX / Windows have warnings. I think we can fix actions later, because all branches will need fixes.
What do you think, @caguero , can we merge so we can move on with the downstream libs?
Looks good! |
As part of the works of gazebo-tooling/gazebodistro#5 bump the use of msgs to major version 6