Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps for Dome: use msgs6 #149

Merged
merged 5 commits into from
Jul 21, 2020
Merged

Update deps for Dome: use msgs6 #149

merged 5 commits into from
Jul 21, 2020

Conversation

j-rivero
Copy link
Contributor

As part of the works of gazebo-tooling/gazebodistro#5 bump the use of msgs to major version 6

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to merge CI first. Also, be sure to sign all commits 😉

Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about updating .gitbug/workflows/ci-bionic.yaml? Otherwise I think CI will break.

@caguero
Copy link
Collaborator

caguero commented Jul 13, 2020

Should we also remove bitbucket-pipelines?

@j-rivero
Copy link
Contributor Author

How about updating .gitbug/workflows/ci-bionic.yaml? Otherwise I think CI will break.

I would like to avoid the duplication of build-from-source dependencies (we already do that in release-tools) since it adds a good amount of overhead to manage changes in all the repositories, at least until we have a common solution in place. We can discuss this within the project, it is a structural problem of having CI code in many different places.

Should we also remove bitbucket-pipelines?

We are still using it to determine the platform to build branches. That functionality needs to be migrated first.

@chapulina
Copy link
Contributor

chapulina commented Jul 16, 2020

Pending CI fixes:

Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero
Copy link
Contributor Author

Github actions are reporting green although it is a false positive, related to gazebo-tooling/action-gz-ci#11.

In order to make it work properly with nightlies we need gazebo-tooling/action-gz-ci#12 and change this repo to use gzdev_project_name.

@chapulina
Copy link
Contributor

@osrf-jenkins run tests please

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Jenkins CI is passing. OSX has 1 test failure and OSX / Windows have warnings. I think we can fix actions later, because all branches will need fixes.

What do you think, @caguero , can we merge so we can move on with the downstream libs?

@caguero
Copy link
Collaborator

caguero commented Jul 21, 2020

All Jenkins CI is passing. OSX has 1 test failure and OSX / Windows have warnings. I think we can fix actions later, because all branches will need fixes.

What do you think, @caguero , can we merge so we can move on with the downstream libs?

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants