Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use msgs6/fuel-tools5/physics3/gazebo4/sdf10 in ignition-dome #5

Merged
merged 11 commits into from
Jul 9, 2020

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Jun 8, 2020

We need to create the branches first. Not sure if we want prereleases too.

@chapulina
Copy link
Contributor

No need for pre-releases yet, I think we can go on with master like we're doing for ign-gazebo, ign-rendering, etc.

I think we should also update all individual libraries to stay in sync, not just collection-dome. So this needs to be updated for example:

https://github.com/ignition-tooling/gazebodistro/blob/b7d693226e13b8b83be9008e6be6a21256c5e29d/ign-gazebo4.yaml#L26-L29

@j-rivero j-rivero marked this pull request as ready for review June 9, 2020 15:57
@j-rivero j-rivero requested a review from chapulina June 9, 2020 15:57
@j-rivero
Copy link
Contributor Author

j-rivero commented Jun 9, 2020

No need for pre-releases yet, I think we can go on with master like we're doing for ign-gazebo, ign-rendering, etc.

I think we should also update all individual libraries to stay in sync, not just collection-dome. So this needs to be updated for example:

thanks, updated.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks right to me. But I think we need the bumps in the source code before merging.

@j-rivero
Copy link
Contributor Author

It all looks right to me. But I think we need the bumps in the source code before merging.

Both ign-msgs and ign-fuel-tools have the master branch bumped to 6 and 5 major versions. Do we need to do anything more there?

@chapulina
Copy link
Contributor

chapulina commented Jun 22, 2020

Oh sorry, I meant the downstream packages' find_package calls need to be updated to find these versions.


Here's a list of everything I think needs to be done when bumping a library's version for the upcoming collection:

Since we need to bump all of these for Dome, that's going to be a lot of PRs to a lot of downstream dependencies all the way up to ign-launch. So I think we may want to break them into chunks.

  • sdformat10
  • ign-physics3
  • ign-fuel-tools5
  • ign-msgs6
  • ign-transport9

@j-rivero
Copy link
Contributor Author

thanks for the summary! I start to work on the different points.

@scpeters
Copy link
Contributor

I updated just one file in 2de7bcb, but the correct branch for sdformat10 is sdf10; master is already receiving changes for libsdformat11

@j-rivero
Copy link
Contributor Author

I updated just one file in 2de7bcb, but the correct branch for sdformat10 is sdf10; master is already receiving changes for libsdformat11

thanks!

collection-dome.yaml Show resolved Hide resolved
ign-gazebo4.yaml Outdated Show resolved Hide resolved
ign-gui4.yaml Outdated Show resolved Hide resolved
ign-launch3.yaml Outdated Show resolved Hide resolved
ign-launch3.yaml Show resolved Hide resolved
collection-dome.yaml Show resolved Hide resolved
@j-rivero j-rivero changed the title Use msgs6/fuel-tools5 in ignition-dome Use msgs6/fuel-tools5/physics3/gazebo4/sdf10 in ignition-dome Jul 9, 2020
@j-rivero j-rivero merged commit ee574b2 into master Jul 9, 2020
@j-rivero j-rivero deleted the update_dome branch July 9, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants