-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cmake 3.22.1 features in Ionic #350
Comments
A brief summary of additions can be found here. Simpler than checking all the release notes. Here is an initial list:
|
since Harmonic has already dropped support for 20.04, I think we can target cmake 3.22.1 since that is in 22.04 |
Part of #350. Signed-off-by: Steve Peters <[email protected]>
bumping the required cmake version in we can start using new features in follow-up pull requests |
Part of #350. Signed-off-by: Steve Peters <[email protected]>
having worked with some of the |
I'm always in favor of less code! |
Just a note that |
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
* Enable GitHub workflow on Ubuntu Noble * Require cmake version 3.22.1 Part of gazebosim/gz-cmake#350. * Remove old ruby cmake code * Remove old python cmake code Also don't need to install python3-distutils anymore. Signed-off-by: Steve Peters <[email protected]>
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
* Only run workflows on pull requests or release / main branches. * Use checkout@v4. * Require cmake version 3.22.1, remove old cmake code Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
* Require cmake version 3.22.1, remove old cmake code Part of gazebosim/gz-cmake#350. * No more special handling of PYTHON_DEBUG_LIBRARIES * Remove distutils logic for cmake < 3.12 Signed-off-by: Steve Peters <[email protected]>
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
* Part of gazebosim/gz-cmake#350. * Remove old cmake code * Use Python3_EXECUTABLE, not GZ_PYTHON_EXECUTABLE * Remove logic for skipping tests with old cmake Signed-off-by: Steve Peters <[email protected]>
I just noticed from What's new in cmake that the |
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
Part of gazebosim/gz-cmake#350. Also fix push branch regex to support double digit major versions. Signed-off-by: Steve Peters <[email protected]>
* Part of gazebosim/gz-cmake#350. * Fix push branch regex to support multi-digit versions. * Fix README CI badges. Signed-off-by: Steve Peters <[email protected]>
* Part of gazebosim/gz-cmake#350. * Fix push branch regex to support multi-digit versions. * Fix README CI badges. Signed-off-by: Steve Peters <[email protected]>
* Part of gazebosim/gz-cmake#350. * Fix push branch regex to support multi-digit versions. * Fix README CI badges. Signed-off-by: Steve Peters <[email protected]>
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
* Part of gazebosim/gz-cmake#350. * Fix push branch regex to support multi-digit versions. * Fix README CI badges * Remove logic for outdated cmake version * Add packages-noble.apt for ogre-next-2.3, vulcan * waves.cc: fix msvc warnings Signed-off-by: Steve Peters <[email protected]> Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
Desired behavior
The next major release of gz-cmake will be supported on newer distributions with newer versions of cmake than version 3.10.2 that is currently used in gz-cmake3. We should identify which version of cmake we can target in order to use those new features.
Alternatives considered
Continue using cmake 3.10.2.
Implementation suggestion
Look into updating the following places where it is suggested that a new version of cmake will allow changes:
GzFindPackage.cmake:286-328gz-config.cmake.in:86-88Additional context
The text was updated successfully, but these errors were encountered: