Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find python directly instead of using GzPython #990

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of gazebosim/gz-cmake#350.

Summary

I suggested in gazebosim/gz-cmake#350 (comment) that we find python directly so that GzPython can be deprecated, and this is a step towards that goal.

Test it

Compile and run tests and verify that the check_test_ran.py script still runs.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 merged commit e986a34 into main Apr 18, 2024
6 of 7 checks passed
@iche033 iche033 deleted the scpeters/find_python_directly branch April 18, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants