Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add geospatial component #4

Merged
merged 4 commits into from
Mar 15, 2022
Merged

Add geospatial component #4

merged 4 commits into from
Mar 15, 2022

Conversation

scpeters
Copy link
Contributor

Follow-up to gazebosim/gz-common#267. I may suggest some additional changes to the header file locations, since I believe the Heightmap header files are not in the geospatial subfolder.

@scpeters
geospatial component
fc4acc6 
Follow-up to gazebosim/gz-common#267

Signed-off-by: Steve Peters <[email protected]>
@scpeters
Copy link
Contributor Author

testing: Build Status https://build.osrfoundation.org/view/ign-garden/job/ign-common5-debbuilder/140/

iche033
iche033 reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add libignition-common5-geospatial-dev as a dependency for libignition-common5-dev?

ubuntu/debian/control Outdated
libignition-common5-core-dev (= ${binary:Version}),
Depends: libgdal-dev,
libignition-cmake2-dev,
libignition-common5-graphics-dev (= ${binary:Version}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be added under the events component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, no

let me fix it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed by 8555fbc

@iche033 iche033 mentioned this pull request Jan 19, 2022
Merged
7 tasks
@scpeters scpeters mentioned this pull request Jan 19, 2022
Merged
7 tasks
@scpeters
Copy link
Contributor Author

I may suggest some additional changes to the header file locations, since I believe the Heightmap header files are not in the geospatial subfolder.

gazebosim/gz-common#289

@iche033
Copy link
Contributor

iche033 commented Jan 19, 2022

do we need to add libignition-common5-geospatial-dev as a dependency for libignition-common5-dev?

add the dependency here?

@scpeters
Copy link
Contributor Author

do we need to add libignition-common5-geospatial-dev as a dependency for libignition-common5-dev?

add the dependency here?

sorry I missed that comment

added in d56295e

@chapulina
Copy link
Contributor

Latest build worked: Build Status

@scpeters
Copy link
Contributor Author

I may suggest some additional changes to the header file locations, since I believe the Heightmap header files are not in the geospatial subfolder.

ignitionrobotics/ign-common#289

just merged this, so I will rebuild the focal nightly

@scpeters
Copy link
Contributor Author

perhaps we should drop the bionic metadata as a follow-up to gazebosim/gz-common#270 ?

@chapulina chapulina merged commit aca14a6 into main Mar 15, 2022
@chapulina chapulina deleted the scpeters/geospatial branch March 15, 2022 00:54
@j-rivero j-rivero mentioned this pull request Mar 16, 2022
Merged
@scpeters scpeters mentioned this pull request Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 left review comments

@j-rivero j-rivero Awaiting requested review from j-rivero

@chapulina chapulina Awaiting requested review from chapulina

@jennuine jennuine Awaiting requested review from jennuine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scpeters @iche033 @chapulina