Add common::testing module #314
Conversation
mjcarroll
force-pushed
the
add_common_testing
branch
from
052f550
to
6c0ac04
Compare
Codecov Report
@@ Coverage Diff @@
## main #314 +/- ##
==========================================
- Coverage 77.14% 77.13% -0.01%
==========================================
Files 76 84 +8
Lines 10547 10661 +114
==========================================
+ Hits 8136 8223 +87
- Misses 2411 2438 +27
Continue to review full report at Codecov.
|
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
add_common_testing
branch
from
6c0ac04
to
8d01233
Compare
|
should this go in ign-utils so it can be used by ign-math and ign-plugin? |
I think ign-utils is pretty safe because it doesn't have a lot of need for it. In theory we could make the dependency from ign-plugin to ign-common purely for the tests, but this really only works if you are building an entire source workspace with colcon or bazel rather than depending on packaged binaries. |
|
ign-plugin also circumvents this a bit by directly injecting paths to libraries in the tests via preprocessor definitions. It works fine for a few examples and is probably okay because plugin assumes that most of the path munging will have already been handed by common. |
|
@osrf-jenkins retest this please |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
add_common_testing
branch
from
9e3a6fc
to
377e67d
Compare
|
@osrf-jenkins retest this please |
|
@osrf-jenkins retest this please |
|
#337 should fix the Windows CI |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
|
we need to update the ign-common5-release repo with this new component, similar to gazebo-release/gz-common5-release#4 |
Will do, thanks |
|
🎉 New feature
Summary
This introduces
ignition::common::testing, a component to hold all of our testing support functionality.The main motivation is to do away with
test_config.h.infiles across our components, and provide a more reliable way of getting source files, test support files, and temporary directories from the file system.This should end up with any uses of
PROJECT_SOURCE_PATHorCMAKE_SOURCE_PATHremoved from our codebase in a centralized module.I also envision this holding other common functionality, such as forking executables as part of a test.
Test it
See #315 for how this is used
Requires gazebosim/gz-cmake/pull/206