Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility for Windows #337

Merged
merged 3 commits into from
Apr 5, 2022
Merged

Conversation

mjcarroll
Copy link
Contributor

Should fix Windows CI for #314

Signed-off-by: Michael Carroll [email protected]

Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll self-assigned this Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #337 (ff0d8f0) into add_common_testing (0dc5711) will not change coverage.
The diff coverage is n/a.

❗ Current head ff0d8f0 differs from pull request most recent head 22ec9f2. Consider uploading reports for the commit 22ec9f2 to get more accurate results

@@                 Coverage Diff                 @@
##           add_common_testing     #337   +/-   ##
===================================================
  Coverage               77.15%   77.15%           
===================================================
  Files                      84       84           
  Lines                   10643    10643           
===================================================
  Hits                     8212     8212           
  Misses                   2431     2431           
Impacted Files Coverage Δ
.../include/ignition/common/testing/BazelTestPaths.hh 0.00% <ø> (ø)
.../include/ignition/common/testing/CMakeTestPaths.hh 100.00% <ø> (ø)
...sting/include/ignition/common/testing/TestPaths.hh 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc5711...22ec9f2. Read the comment docs.

Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll merged commit 84dbb6c into add_common_testing Apr 5, 2022
@mjcarroll mjcarroll deleted the common_testing_visibility branch April 5, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant