Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign-common5: drop Bionic #270

Merged
merged 2 commits into from
Nov 19, 2021
Merged

ign-common5: drop Bionic #270

merged 2 commits into from
Nov 19, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Nov 19, 2021

🎉 New feature

Summary

Testing CI update to Jammy. It doesn't work yet, see gazebo-tooling/release-tools#566

So this PR just drops Bionic to unblock #267.

Note that even if ign-common5 doesn't go into Garden (discussion in gazebo-tooling/release-tools#567, it will end up in a future version that doesn't support Bionic.

Test it

See CI results.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina changed the title Garden: Drop Bionic, support Jammy Garden: drop Bionic Nov 19, 2021
@chapulina chapulina added the 🌱 garden Ignition Garden label Nov 19, 2021
@chapulina chapulina marked this pull request as ready for review November 19, 2021 21:03
@chapulina chapulina added the tests Broken or missing tests / testing infra label Nov 19, 2021
@chapulina chapulina changed the title Garden: drop Bionic ign-common5: drop Bionic Nov 19, 2021
@mjcarroll mjcarroll merged commit 38c3c33 into main Nov 19, 2021
@mjcarroll mjcarroll deleted the chapulina/5/jammy branch November 19, 2021 21:42
@chapulina chapulina mentioned this pull request Dec 24, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants