Move geospatial headers to subfolder #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the logic required for packaging. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
scpeters
changed the title
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
=======================================
Coverage 76.69% 76.69%
=======================================
Files 76 76
Lines 10647 10647
=======================================
Hits 8166 8166
Misses 2481 2481
Continue to review full report at Codecov.
|
chapulina
approved these changes
Jan 19, 2022
jennuine
reviewed
Jan 19, 2022
Migration.md
Outdated
| @@ -17,7 +17,8 @@ release will remove the deprecated code. | |||
| 1. `HeightmapData.hh` and `ImageHeightmap.hh` have been moved out of the | |||
| `graphics` component and into the new `geospatial` component | |||
| + To use the heightmap features, users must add the `geospatial` component | |||
| to the `find_package` call | |||
| to the `find_package` call and update the include paths to use | |||
| the geospatial subfolder (`#include <ignition/common/geospatial/Dem.hh>`) | |||
There was a problem hiding this comment.
Since Dem is a new feature, how about we use ImageHeightmap.hh as an example instead?
Suggested change
| the geospatial subfolder (`#include <ignition/common/geospatial/Dem.hh>`) | |
| the geospatial subfolder (e.g., `#include <ignition/common/geospatial/ImageHeightmap.hh>`) |
There was a problem hiding this comment.
I used HeightmapData.hh in c3d6053
Signed-off-by: Steve Peters <[email protected]>
7 tasks
|
the homebrew CI didn't build the |
scpeters
added a commit
to scpeters/ign-common
that referenced
this pull request
Jan 19, 2022
This reverts commit e0a5490. Signed-off-by: Steve Peters <[email protected]>
7 tasks
mjcarroll
pushed a commit
that referenced
this pull request
Jan 19, 2022
* Revert "Move geospatial headers to subfolder (#289)" This reverts commit e0a5490. Signed-off-by: Steve Peters <[email protected]> * Revert "Geospatial component for heightmap & DEMs (#267)" This reverts commit 28eb6c7. Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
that referenced
this pull request
Jan 21, 2022
This simplifies the logic required for packaging. Update Migration guide Signed-off-by: Steve Peters <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Follow-up to #267, connected to gazebo-release/gz-common5-release#4
Summary
This simplifies the logic required for packaging by putting all the geospatial header files in a subfolder. We haven't done this for the other ing-common components, but now is an easy time to do it for geospatial since we are already breaking things with this component.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.