Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put stars in long tuple in long signature at the end. #1991

Closed
wants to merge 31 commits into from
Closed

Put stars in long tuple in long signature at the end. #1991

wants to merge 31 commits into from

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Dec 4, 2021

WIP, related to fsharp/fslang-design#644.
Style guide would need an update before we can merge this.
@dsyme and I did discuss this in person though.

nojaf and others added 30 commits November 24, 2021 19:46
@nojaf
Upgrade to FCS 40 (fsprojects#1856)
12ed561 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
@nojaf
Add release notes for 4.6.0-alpha-001.
b41743d
@nojaf
Style guide lambda (fsprojects#1858)
783a5bd 
* WIP lambda as last argument

* Update remaining test according to style proposal.

* Add test for multiline non lambda argument.

* Print trivia for function keyword from ast range.

* multiline non lambda argument, match lambda
@nojaf
Add release notes for 4.6.0-alpha-002.
76a7f92
@nojaf
Update records indent from the curly brace (fsprojects#1892)
df51471 
* Update records indent from the curly brace.
Fixes fsprojects#1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
@nojaf
Add release notes for 4.6.0-alpha-003.
f683bee
@nojaf
Format out of process (fsprojects#1845)
f8b5c07 
* Style guide lambda (fsprojects#1858)

* WIP lambda as last argument

* Update remaining test according to style proposal.

* Add test for multiline non lambda argument.

* Print trivia for function keyword from ast range.

* multiline non lambda argument, match lambda

* WIP Daemon service contract.

* Early working daemon prototype.

* Take .editorconfig settings into account.

* Fix current build.

* Add Fantomas locator.

* Found globally installed Fantomas version.

* Remove unused function.

* Add formatSelection.

* Refactor FormatDocumentResponse to DU.

* Remove unused LspTypes dependency.

* Update FCS in Daemon

* Refactored public api of FantomasService.

* Don't pass full exception in FormatDocumentResponse.

* Use separate versioning for Fantomas.Client.

* FantomasService manages multiple daemon versions.

* Fully implement FantomasService.

* Return configuration as json.

* Validate if filePath in request is absolute.

* Ignore first three 4.6 alphas as compatible tools.

* Find ignore file from current file path.

* Remove safeFileName from CodeFormatterImpl.fs.
Disable daemon tests.

* Add daemon unit tests.

* Update help text for daemon mode.

* Add documentation for Fantomas daemon mode.

* Initial attempt at adding source links.

* Set DebugType to embedded.

* Bump Fantomas.Client to 0.3.0
@nojaf
Don't add a newline if there are no additional arguments before lambd…
ee51ff8 
…a. (fsprojects#1923)

Fixes fsprojects#1922.
@nojaf
Set DOTNET_CLI_UI_LANGUAGE to en-us when running dotnet tool command. (…
cd7e097 
…fsprojects#1925)

* Set DOTNET_CLI_UI_LANGUAGE to en-us when running dotnet tool command.

* Add RepositoryUrl.

* Bump Fantomas.Client version to 0.3.1
@nojaf
Update FCS to 41.0.0-preview.21472.3 (fsprojects#1927)
ec2ecb6 
* Update FCS to 41.0.0-preview.21472.3

* If, elif, then and else keyword are present in AST.

* Use arrow range from SyntaxTree instead of trivia tokens.

* Processed change of FCS 40.0.1-preview.21423.4.

* Support expr[idx] as index/slice syntax.

* Remove ArrayOrListComputedExpr active pattern.

* Apply style guide rules for SynExpr.IndexRange.

* Always use LangVersionText preview.

* Remove Verbose tests.

* Change QuoteIdentifierIfNeeded to AddBackticksToIdentifierIfNeeded.
@nojaf
Add release notes for 4.6.0-alpha-005.
e0cbca1
@dsyme @nojaf
Fix fsprojects#1937 (fsprojects#1938)
b970671 
* fix 1937

* fix format

* Use formatSourceString in unit test.

Co-authored-by: nojaf <[email protected]>
@nojaf
Create parsingOption via CodeFormatterImpl helper. (fsprojects#1946)
7db7213
@nojaf @dsyme
wider default fsharp_max_value_binding_width, also take width of patt…
610007d 
…ern of binding into account (fsprojects#1947)

Co-authored-by: Don Syme <[email protected]>
@nojaf
Add release notes for 4.6.0-alpha-006.
18602e3
@nojaf
Update FSharp.Compiler.Service to 41.0.1 (fsprojects#1949)
b46b03b
@nojaf
Remove unused code after FCS upgrade. (fsprojects#1950)
f02c468
@nojaf @deviousasti
Config documentation (fsprojects#1956)
8655a30 
* Add documentation attribute

* Expose documentation attributes via Fantomas Daemon.

Co-authored-by: Asti <[email protected]>
@nojaf
Add release notes for 4.6.0-alpha-007.
4819b25
@nojaf
Add ticks to mod identifier. Fixes fsprojects#1960. (fsprojects#1963)
ce836af
@nojaf
New Index syntax on raw list. Fixes fsprojects#1929. (fsprojects#1964)
3adc2c7
@nojaf
Add release notes for 4.6.0-alpha-008.
8668473
@nojaf
Set CreateNoWindow to false when spinning up a Fantomas process.
b96c269
@nojaf
Set CreateNoWindow to true when spinning up a Fantomas process.
f182978
@nojaf
Set CreateNoWindow to true when running dotnet tool list.
23e76f0
@nojaf
Restart fantomas-tool when process has exited. (fsprojects#1977)
74c9aff 
* Restart fantomas-tool when process has exited.

* Use LSPFantomasService cancellationToken if user does not provide one.

* Bump Fantomas.Client version to 0.4.0
@nojaf
Use FullRange for SynExceptionDefnRepr, SynExceptionSig and SynModule…
1977272 
…SigDecl. Fixes fsprojects#1974. (fsprojects#1978)
@nojaf
Add release notes for 4.6.0-alpha-009.
29d3462
@nojaf
Add more detailed information when the daemon fails to start. (fsproj…
3f48414 
…ects#1983)

* Add more detailed information when the daemon fails to start.

* Capture working directory when ExecutableFileNotFound.
@nojaf
Improve Fantomas Daemon detection (fsprojects#1987)
afd6a1c 
* Pass correct arguments for global tool.

* Use absolute path to launch global tool.

* Use SemanticVersioning to verify the supported version.

* Add support for when Fantomas is on the PATH.

* Bump version 0.5.0
@baronfel
Copy link
Contributor

baronfel commented Dec 4, 2021

Re: style guide change, would that also require FSAC changes to align with this formatting?

@nojaf
Copy link
Contributor Author

nojaf commented Dec 4, 2021

That would be nice, but I'm really jumping the gun here by already having an implementation for this.
One benefit is that we discovered when you need the extra indent (after tuples) for example.

@dsyme
Copy link
Contributor

dsyme commented Dec 4, 2021

@nojaf I guess given our conversation at NDC we can consider the stile guide change pre-approved. I'll work on a PR next week

@nojaf
Copy link
Contributor Author

nojaf commented Dec 4, 2021

Yes, I was thinking along the same lines.

@nojaf nojaf closed this Dec 10, 2021
@nojaf nojaf deleted the stars-at-end branch December 10, 2021 08:53
@nojaf nojaf restored the stars-at-end branch December 10, 2021 08:53
@nojaf nojaf reopened this Dec 10, 2021
@nojaf nojaf closed this Dec 10, 2021
@nojaf nojaf mentioned this pull request Dec 10, 2021
Merged
@nojaf nojaf deleted the stars-at-end branch December 10, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nojaf @baronfel @dsyme