Improve Fantomas Daemon detection #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
reviewed
Dec 1, 2021
nojaf
added a commit
that referenced
this pull request
Dec 4, 2021
* Pass correct arguments for global tool. * Use absolute path to launch global tool. * Use SemanticVersioning to verify the supported version. * Add support for when Fantomas is on the PATH. * Bump version 0.5.0
nojaf
added a commit
that referenced
this pull request
Dec 29, 2021
* Pass correct arguments for global tool. * Use absolute path to launch global tool. * Use SemanticVersioning to verify the supported version. * Add support for when Fantomas is on the PATH. * Bump version 0.5.0
nojaf
added a commit
that referenced
this pull request
Jan 7, 2022
* Pass correct arguments for global tool. * Use absolute path to launch global tool. * Use SemanticVersioning to verify the supported version. * Add support for when Fantomas is on the PATH. * Bump version 0.5.0
nojaf
added a commit
that referenced
this pull request
Jan 8, 2022
* Pass correct arguments for global tool. * Use absolute path to launch global tool. * Use SemanticVersioning to verify the supported version. * Add support for when Fantomas is on the PATH. * Bump version 0.5.0
nojaf
added a commit
that referenced
this pull request
Jan 8, 2022
* Pass correct arguments for global tool. * Use absolute path to launch global tool. * Use SemanticVersioning to verify the supported version. * Add support for when Fantomas is on the PATH. * Bump version 0.5.0
nojaf
added a commit
that referenced
this pull request
Jan 14, 2022
* Pass correct arguments for global tool. * Use absolute path to launch global tool. * Use SemanticVersioning to verify the supported version. * Add support for when Fantomas is on the PATH. * Bump version 0.5.0
nojaf
added a commit
that referenced
this pull request
Jan 14, 2022
* Pass correct arguments for global tool. * Use absolute path to launch global tool. * Use SemanticVersioning to verify the supported version. * Add support for when Fantomas is on the PATH. * Bump version 0.5.0
jindraivanek
pushed a commit
to jindraivanek/fantomas
that referenced
this pull request
Mar 30, 2022
* Pass correct arguments for global tool. * Use absolute path to launch global tool. * Use SemanticVersioning to verify the supported version. * Add support for when Fantomas is on the PATH. * Bump version 0.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR means to address #1982.
It starts global tool using the absolute path.
And adds support for just having Fantomas on your PATH.
I should do more testing but could use a review by @baronfel if that works.