Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update records indent from the curly brace #1892

Merged
merged 5 commits into from
Sep 27, 2021
Merged

Update records indent from the curly brace #1892

merged 5 commits into from
Sep 27, 2021

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Sep 16, 2021

Fixes #1876.
I do still need to take anonymous records into account.

@nojaf nojaf requested a review from dsyme September 22, 2021 19:12
@nojaf
Copy link
Contributor Author

nojaf commented Sep 22, 2021

Would you mind reviewing the unit tests @dsyme?
I believe all cases are now indented correctly from the { or {|, with a few limitations when the indent_size is too small.

@dsyme
Copy link
Contributor

dsyme commented Sep 24, 2021

The testing looks great

@nojaf nojaf merged commit fed7d42 into fsprojects:4.6 Sep 27, 2021
@nojaf nojaf deleted the fix-1876 branch September 27, 2021 13:09
nojaf added a commit that referenced this pull request Sep 29, 2021
@nojaf
Update records indent from the curly brace (#1892)
1e8f4d0 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Oct 5, 2021
@nojaf
Update records indent from the curly brace (#1892)
8d810a7 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Oct 7, 2021
@nojaf
Update records indent from the curly brace (#1892)
295d71a 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Oct 8, 2021
@nojaf
Update records indent from the curly brace (#1892)
c97e732 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Oct 18, 2021
@nojaf
Update records indent from the curly brace (#1892)
b96fe57 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Oct 20, 2021
@nojaf
Update records indent from the curly brace (#1892)
2bcf620 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Oct 26, 2021
@nojaf
Update records indent from the curly brace (#1892)
1679ca7 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Oct 27, 2021
@nojaf
Update records indent from the curly brace (#1892)
f460762 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Nov 2, 2021
@nojaf
Update records indent from the curly brace (#1892)
cd15f6b 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Nov 3, 2021
@nojaf
Update records indent from the curly brace (#1892)
bd0ba0e 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Nov 7, 2021
@nojaf
Update records indent from the curly brace (#1892)
430b51a 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Nov 9, 2021
@nojaf
Update records indent from the curly brace (#1892)
f5453a6 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Nov 10, 2021
@nojaf
Update records indent from the curly brace (#1892)
915fe0f 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Nov 19, 2021
@nojaf
Update records indent from the curly brace (#1892)
14e3816 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Nov 24, 2021
@nojaf
Update records indent from the curly brace (#1892)
df51471 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Dec 4, 2021
@nojaf
Update records indent from the curly brace (#1892)
25bc748 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Dec 29, 2021
@nojaf
Update records indent from the curly brace (#1892)
d14a1a1 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Jan 7, 2022
@nojaf
Update records indent from the curly brace (#1892)
dc9bb21 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Jan 8, 2022
@nojaf
Update records indent from the curly brace (#1892)
bb2c830 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Jan 8, 2022
@nojaf
Update records indent from the curly brace (#1892)
e21e658 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Jan 14, 2022
@nojaf
Update records indent from the curly brace (#1892)
4320f95 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
nojaf added a commit that referenced this pull request Jan 14, 2022
@nojaf
Update records indent from the curly brace (#1892)
2375bb3 
* Update records indent from the curly brace.
Fixes #1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
jindraivanek pushed a commit to jindraivanek/fantomas that referenced this pull request Mar 30, 2022
@nojaf @jindraivanek
Update records indent from the curly brace (fsprojects#1892)
902ee63 
* Update records indent from the curly brace.
Fixes fsprojects#1876.

* WIP anonymous records

* Indent multiline record field expressions from the opening brace.

* Restore correct indent after update record expression.

* trigger CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsyme dsyme dsyme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nojaf @dsyme