Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to FCS 40 #1856

Merged
merged 6 commits into from
Aug 7, 2021
Merged

Upgrade to FCS 40 #1856

merged 6 commits into from
Aug 7, 2021

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Aug 7, 2021

This upgrades FCS to https://www.nuget.org/packages/FSharp.Compiler.Service/40.0.1-preview.21352.5.
As certain ranges have been correct in the parser, some workaround we had to deal with these have been removed.
Example sepNlnConsideringTriviaContentBeforeWithAttributesFor and linesBetweenParent in TriviaNodeAssigner.

@nojaf nojaf merged commit 11e3379 into 4.6 Aug 7, 2021
@nojaf nojaf deleted the fcs-40 branch August 7, 2021 08:20
nojaf added a commit that referenced this pull request Aug 10, 2021
@nojaf
Upgrade to FCS 40 (#1856)
cf7351c 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Aug 11, 2021
@nojaf
Upgrade to FCS 40 (#1856)
ac0fa7b 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Aug 11, 2021
@nojaf
Upgrade to FCS 40 (#1856)
2160491 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Aug 23, 2021
@nojaf
Upgrade to FCS 40 (#1856)
0801787 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Sep 7, 2021
@nojaf
Upgrade to FCS 40 (#1856)
bac7f35 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Sep 10, 2021
@nojaf
Upgrade to FCS 40 (#1856)
bb42fbb 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Sep 16, 2021
@nojaf
Upgrade to FCS 40 (#1856)
7d96416 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Sep 22, 2021
@nojaf
Upgrade to FCS 40 (#1856)
ab1671c 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Sep 27, 2021
@nojaf
Upgrade to FCS 40 (#1856)
fb49652 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Sep 29, 2021
@nojaf
Upgrade to FCS 40 (#1856)
57ed045 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Oct 5, 2021
@nojaf
Upgrade to FCS 40 (#1856)
ee18e14 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Oct 7, 2021
@nojaf
Upgrade to FCS 40 (#1856)
7c9461b 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Oct 8, 2021
@nojaf
Upgrade to FCS 40 (#1856)
7502ce0 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Oct 18, 2021
@nojaf
Upgrade to FCS 40 (#1856)
5996c7f 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Oct 20, 2021
@nojaf
Upgrade to FCS 40 (#1856)
99ca760 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Oct 26, 2021
@nojaf
Upgrade to FCS 40 (#1856)
dfe3607 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Oct 27, 2021
@nojaf
Upgrade to FCS 40 (#1856)
a193424 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Nov 2, 2021
@nojaf
Upgrade to FCS 40 (#1856)
e092808 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Nov 3, 2021
@nojaf
Upgrade to FCS 40 (#1856)
806fee0 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Nov 7, 2021
@nojaf
Upgrade to FCS 40 (#1856)
c99c018 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Nov 9, 2021
@nojaf
Upgrade to FCS 40 (#1856)
c3b72ba 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Nov 10, 2021
@nojaf
Upgrade to FCS 40 (#1856)
05ee9f6 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Nov 19, 2021
@nojaf
Upgrade to FCS 40 (#1856)
986fd18 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Nov 24, 2021
@nojaf
Upgrade to FCS 40 (#1856)
12ed561 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Dec 4, 2021
@nojaf
Upgrade to FCS 40 (#1856)
1dd805b 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Dec 29, 2021
@nojaf
Upgrade to FCS 40 (#1856)
d9a9535 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Jan 7, 2022
@nojaf
Upgrade to FCS 40 (#1856)
3bbcc5c 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Jan 8, 2022
@nojaf
Upgrade to FCS 40 (#1856)
02b981b 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Jan 8, 2022
@nojaf
Upgrade to FCS 40 (#1856)
5448dbe 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Jan 14, 2022
@nojaf
Upgrade to FCS 40 (#1856)
c83631b 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
nojaf added a commit that referenced this pull request Jan 14, 2022
@nojaf
Upgrade to FCS 40 (#1856)
619edb5 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
jindraivanek pushed a commit to jindraivanek/fantomas that referenced this pull request Mar 30, 2022
@nojaf @jindraivanek
Upgrade to FCS 40 (fsprojects#1856)
155457f 
* Initial upgrade to FCS 40.

* Fix remaining unit tests.

* Remove AST workaround for Attributes.

* Update for SynTyparDecls, SynPat.As and ParsedHashDirectiveArgument.

* Re-enable ignored tests.

* Update to FCS 40.0.1-preview.21366.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nojaf